Page MenuHomeSoftware Heritage

Log the correct target directory when cloning
ClosedPublic

Authored by Alphare on Jan 20 2022, 11:59 AM.

Details

Summary

This used to always output None.

Diff Detail

Repository
rDLDHG Mercurial loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D6987 (id=25343)

Could not rebase; Attempt merge onto 2180cbbbbe...

Updating 2180cbb..8033b52
Fast-forward
 swh/loader/mercurial/hgutil.py            | 81 +++++--------------------------
 swh/loader/mercurial/loader.py            |  2 +-
 swh/loader/mercurial/tests/test_hgutil.py | 51 -------------------
 3 files changed, 14 insertions(+), 120 deletions(-)
 delete mode 100644 swh/loader/mercurial/tests/test_hgutil.py
Changes applied before test
commit 8033b5265cc6291cd2ba3cdc5b3bec8e1993f46b
Author: Raphaël Gomès <rgomes@octobus.net>
Date:   Thu Jan 20 11:58:18 2022 +0100

    Log the correct target directory when cloning
    
    This used to always output `None`.

commit 2877216902a468cd7fb2508725b6bcdea5330fd2
Author: Raphaël Gomès <rgomes@octobus.net>
Date:   Wed Jan 19 19:23:05 2022 +0100

    Refactor clone util with the one in core
    
    This "clone with timout" util just moved to core, let's use it.
    The tests are not relevant anymore, delete them.

Link to build: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/326/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/326/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 20 2022, 12:00 PM
Harbormaster failed remote builds in B26189: Diff 25343!

Build has FAILED

Patch application report for D6987 (id=25408)

Rebasing onto 2877216902...

Current branch diff-target is up to date.
Changes applied before test
commit 8033b5265cc6291cd2ba3cdc5b3bec8e1993f46b
Author: Raphaël Gomès <rgomes@octobus.net>
Date:   Thu Jan 20 11:58:18 2022 +0100

    Log the correct target directory when cloning
    
    This used to always output `None`.

Link to build: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/328/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/328/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 21 2022, 1:48 PM
Harbormaster failed remote builds in B26251: Diff 25408!

Build is green

Patch application report for D6987 (id=25802)

Rebasing onto 6290d72937...

Current branch diff-target is up to date.
Changes applied before test
commit b080d16a470f09b21550c69d8b94cadf0a50fa90
Author: Raphaël Gomès <rgomes@octobus.net>
Date:   Thu Jan 20 11:58:18 2022 +0100

    Log the correct target directory when cloning
    
    This used to always output `None`.

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/331/ for more details.

This revision is now accepted and ready to land.Feb 8 2022, 11:04 AM