Page MenuHomeSoftware Heritage

Refactor clone with timout util from hg loader
ClosedPublic

Authored by Alphare on Jan 19 2022, 7:16 PM.

Details

Summary

This will be also used by the new bzr loader. A separate patch will
refactor this in the hg loader.

Diff Detail

Repository
rDLDHG Mercurial loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6984 (id=25331)

Rebasing onto 2413cb9ff9...

Current branch diff-target is up to date.
Changes applied before test
commit 90736d75d57713eff1a79b15fc59be08cb2861a4
Author: Raphaël Gomès <rgomes@octobus.net>
Date:   Wed Jan 19 19:14:30 2022 +0100

    Refactor clone with timout util from hg loader
    
    This will be also used by the new bzr loader. A separate patch will
    refactor this in the hg loader.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/678/ for more details.

Thanks!

Any chance you could add a couple of tests for this?

swh/loader/core/utils.py
62 ↗(On Diff #25331)

I think you can tighten the annotations here

73 ↗(On Diff #25331)

And here

Incorporate tests and typing suggestions

Build is green

Patch application report for D6984 (id=25336)

Rebasing onto 2413cb9ff9...

Current branch diff-target is up to date.
Changes applied before test
commit 43a9570ddb9e7b4d78303b1ed2206a445008d242
Author: Raphaël Gomès <rgomes@octobus.net>
Date:   Wed Jan 19 19:14:30 2022 +0100

    Refactor clone with timout util from hg loader
    
    This will be also used by the new bzr loader. A separate patch will
    refactor this in the hg loader.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/679/ for more details.

Incorporate sigkill and traceback test from hg tests

Build is green

Patch application report for D6984 (id=25339)

Rebasing onto 2413cb9ff9...

Current branch diff-target is up to date.
Changes applied before test
commit 812ccf69ff9b1a6fdd53027249a0af61d540abd9
Author: Raphaël Gomès <rgomes@octobus.net>
Date:   Wed Jan 19 19:14:30 2022 +0100

    Refactor clone with timout util from hg loader
    
    This will be also used by the new bzr loader. A separate patch will
    refactor this in the hg loader.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/680/ for more details.

This revision is now accepted and ready to land.Jan 21 2022, 11:31 AM
This revision was landed with ongoing or failed builds.Jan 21 2022, 1:46 PM
This revision was automatically updated to reflect the committed changes.

Build has FAILED

Patch application report for D6984 (id=25405)

Rebasing onto 2180cbbbbe...

Current branch diff-target is up to date.
Changes applied before test
commit 2877216902a468cd7fb2508725b6bcdea5330fd2
Author: Raphaël Gomès <rgomes@octobus.net>
Date:   Wed Jan 19 19:23:05 2022 +0100

    Refactor clone util with the one in core
    
    This "clone with timout" util just moved to core, let's use it.
    The tests are not relevant anymore, delete them.

Link to build: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/327/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/327/console