Differential D6982

proxmox/terraform: Make the vmid variable properly optional
ClosedPublic
Actions

Authored by olasd on Jan 19 2022, 6:24 PM.

Details

Reviewers

ardumont

Group Reviewers

System administrators

Commits

rSPREde0278bd78dd: proxmox/terraform: Make the vmid variable properly optional

Summary

The current version of the proxmox provider is able to map resources
using their name rather than the vmid.

Test Plan

terraform plan -> no changes; terraform plan on a new VM is happy without providing a vmid

Diff Detail

Repository

rSPRE sysadm-provisioning

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Jan 19 2022, 6:24 PM

Herald added a reviewer: System administrators. · View Herald TranscriptJan 19 2022, 6:24 PM

olasd requested review of this revision.Jan 19 2022, 6:24 PM

Harbormaster completed remote builds in B26178: Diff 25329.Jan 19 2022, 6:24 PM

cool, one less thing to worry about, thx.

This revision is now accepted and ready to land.Jan 19 2022, 7:06 PM

Closed by commit rSPREde0278bd78dd: proxmox/terraform: Make the vmid variable properly optional (authored by olasd). · Explain WhyJan 20 2022, 8:50 AM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rSPREde0278bd78dd: proxmox/terraform: Make the vmid variable properly optional.

Revision Contents
Changeset List

Path

Size

proxmox/

terraform/

modules/

node/

variables.tf

2 lines

production/

production.tf

6 lines

Diff 25334

View Options

proxmox/terraform/modules/node/variables.tf