Page MenuHomeSoftware Heritage
Differential D6975

Fix mypy issue which fails the build
ClosedPublic
Actions

Authored by ardumont on Jan 19 2022, 2:16 PM.

Details

Reviewers
None
Group Reviewers
Reviewers
Commits
rDTSCN544847689206: Fix mypy issue which fails the build
Summary

Fixes build [1]

[1] https://jenkins.softwareheritage.org/view/swh-draft/job/DTSCN/job/tests/811/console

Test Plan

mypy should be happy now
and the build as well

Diff Detail

Repository
rDTSCN Code scanner
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26157
Build 40886: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 40885: arc lint + arc unit

Event Timeline

ardumont created this revision.Jan 19 2022, 2:16 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJan 19 2022, 2:16 PM
ardumont edited the summary of this revision. (Show Details)Jan 19 2022, 2:16 PM
ardumont edited the test plan for this revision. (Show Details)
swh-public-ci added a comment.Jan 19 2022, 2:19 PM

Build is green

Patch application report for D6975 (id=25299)

Rebasing onto 1b97932feb...

Current branch diff-target is up to date.
Changes applied before test
commit 5448476892067cf4d6cabab7d7707e742b9b1262
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jan 19 14:15:53 2022 +0100

    Fix mypy issue which fails the build

See https://jenkins.softwareheritage.org/job/DTSCN/job/tests-on-diff/159/ for more details.

Harbormaster completed remote builds in B26157: Diff 25299.Jan 19 2022, 2:19 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 19 2022, 2:19 PM
ardumont requested review of this revision.
Closed by commit rDTSCN544847689206: Fix mypy issue which fails the build (authored by ardumont). · Explain Why
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDTSCN544847689206: Fix mypy issue which fails the build.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
3 lines--
swh/
scanner/
tests/
4 lines100%
Loading...

Diff 25299

View Options

mypy.ini

Loading...
View Options

swh/scanner/tests/conftest.py

Loading...
About · Developer information · Legal