Page MenuHomeSoftware Heritage

cassandra: Clarify use of '<=' on set-like dict views
AbandonedPublic

Authored by vlorentz on Wed, Jan 12, 11:30 AM.

Details

Reviewers
None
Group Reviewers
Reviewers
Summary

Depends on D6889.

Diff Detail

Repository
rDSTO Storage manager
Branch
concurrent-missing
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25951
Build 40558: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 40557: arc lint + arc unit

Event Timeline

I'll include this in the original diff

Build is green

Patch application report for D6922 (id=25077)

Could not rebase; Attempt merge onto 4a24505049...

Updating 4a245050..748db9bd
Fast-forward
 swh/storage/cassandra/cql.py     |  4 ++--
 swh/storage/cassandra/storage.py | 52 ++++++++++++++++++++++++++++++++++------
 swh/storage/in_memory.py         |  2 +-
 3 files changed, 48 insertions(+), 10 deletions(-)
Changes applied before test
commit 748db9bd8f6469b2ea895af900f4a6aa88c4f135
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Jan 12 11:29:49 2022 +0100

    cassandra: Clarify use of '<=' on set-like dict views

commit 9ee7b92de56a85b7acf8f775573907a1a1f949e2
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jan 7 13:04:25 2022 +0100

    cassandra: Make content_missing run in linear time instead of quadratic
    
    Assuming all contents passed to content_missing() have (at least) a missing algo,
    the function used to iterate over the size of the arg squared
    in the worst case (when all contents are found).
    
    With this commit, it starts with bucketing them by hash, so it does not
    need to iterate over *all* found contents for each content passed as arg.

commit 55141ff2d57ca147efc2235eba2b006814c03817
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Oct 18 13:25:20 2021 +0200

    cassandra: Rewrite content_missing to run queries concurrently.
    
    This is twice as fast, according to
    https://forge.softwareheritage.org/T3577#72791

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1521/ for more details.