Differential D672

tests: clean up
ClosedPublic
Actions

Authored by ardumont on Nov 17 2018, 9:49 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDCIDX84a49c1a87c5: tests: Avoid hard-coding the tool id to check
rDCIDX64b05ab3e413: tests: Remove dead code remnant

Summary

Avoid hard-coding the tool id to check
Remove dead code remnant

Test Plan

tox

Diff Detail

Repository

rDCIDX Metadata indexer

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Nov 17 2018, 9:49 AM

Harbormaster failed remote builds in B2439: Diff 2114!Nov 17 2018, 9:50 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/52/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/52/console

Build has FAILED

because stacked diff does not build yet.

vlorentz accepted this revision.Nov 17 2018, 8:08 PM

This revision is now accepted and ready to land.Nov 17 2018, 8:08 PM

Closed by commit rDCIDX64b05ab3e413: tests: Remove dead code remnant (authored by ardumont). · Explain WhyNov 19 2018, 9:52 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

indexer/

tests/

test_language.py

2 lines

test_metadata.py

4 lines

test_origin_metadata.py

1 line

Diff 2118

View Options

swh/indexer/tests/test_language.py

View Options

swh/indexer/tests/test_metadata.py

View Options

swh/indexer/tests/test_origin_metadata.py

tests: clean upClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 2118

swh/indexer/tests/test_language.py

swh/indexer/tests/test_metadata.py

swh/indexer/tests/test_origin_metadata.py

tests: clean up
ClosedPublic
Actions

Revision Contents
Changeset List