Differential D6670

cvs.tasks: Fix type
ClosedPublic
Actions

Authored by ardumont on Nov 23 2021, 10:59 AM.

Details

Reviewers

None

Group Reviewers

Reviewers

Commits

rDLDCVS1f6580c4c8e3: cvs.tasks: Fix type

Summary

This fixes build [1]

Note that this function should definitely be moved in swh.core because it's redundant
with other definitions in other loaders.

Let's unstuck the build first.

[1] https://jenkins.softwareheritage.org/view/swh-draft/job/DLDSVN/job/tests/1304/console

Diff Detail

Repository

rDLDCVS CVS Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Nov 23 2021, 10:59 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 23 2021, 10:59 AM

Build is green

Patch application report for D6670 (id=24237)

Rebasing onto 34f46486f4...

First, rewinding head to replay your work on top of it...
Applying: cvs.tasks: Fix type

Changes applied before test

commit f00e2be4c1294332ad5cb96904ceecf63d9a5f18
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Nov 23 10:58:14 2021 +0100

    cvs.tasks: Fix type
    
    This fixes build [1]
    
    [1] https://jenkins.softwareheritage.org/view/swh-draft/job/DLDSVN/job/tests/1304/console

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/63/ for more details.

Harbormaster completed remote builds in B25113: Diff 24237.Nov 23 2021, 11:01 AM

ardumont requested review of this revision.Nov 23 2021, 11:01 AM

Rebase

Build is green

Patch application report for D6670 (id=24239)

Rebasing onto 34f46486f4...

Current branch diff-target is up to date.

Changes applied before test

commit 1f6580c4c8e3e3e2b334e2bd3bee54aa3c8ba753
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Nov 23 10:58:14 2021 +0100

    cvs.tasks: Fix type
    
    This fixes build [1]
    
    [1] https://jenkins.softwareheritage.org/view/swh-draft/job/DLDSVN/job/tests/1304/console

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/64/ for more details.

Harbormaster completed remote builds in B25115: Diff 24239.Nov 23 2021, 12:08 PM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 23 2021, 12:09 PM

Closed by commit rDLDCVS1f6580c4c8e3: cvs.tasks: Fix type (authored by ardumont). · Explain Why

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDCVS1f6580c4c8e3: cvs.tasks: Fix type.