Page MenuHomeSoftware Heritage

Remove locks from PostgreSQL backend insertions
ClosedPublic

Authored by aeviso on Tue, Sep 7, 4:53 PM.

Diff Detail

Repository
rDPROV Provenance database
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6209 (id=22472)

Could not rebase; Attempt merge onto 759d39a44c...

Updating 759d39a..73dd6cb
Fast-forward
 swh/provenance/graph.py                 |  15 ----
 swh/provenance/mongo/backend.py         |  12 +--
 swh/provenance/origin.py                |  10 ---
 swh/provenance/postgresql/provenance.py |  15 ++--
 swh/provenance/provenance.py            | 147 +++++++++++++++++---------------
 swh/provenance/revision.py              |  13 ---
 swh/provenance/sql/40-funcs.sql         |  22 ++---
 7 files changed, 97 insertions(+), 137 deletions(-)
Changes applied before test
commit 73dd6cb447739fd0b0f43f1eea73b7f763e4e927
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Tue Sep 7 15:46:20 2021 +0200

    Remove locks from PostgreSQL backend insertions

commit 26061a0a15a0dd1b4694b27750a84e71b79feea9
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Tue Aug 31 13:32:55 2021 +0200

    Remove old debug logging and improve other's messages

commit 00f6d9acfb2ef5ce0527ad2bf625457063f808ba
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Fri Aug 20 12:10:28 2021 +0200

    Avoid flushing empty buffers in the `Provenance` backend
    
    Also, remove the use of f-strings when logging to avoid unnecessary
    parameter resolution.

commit bd6de9eaba198199536df2677bee0332af02f8b3
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Fri Sep 3 16:21:58 2021 +0200

    Fix two minor bugs on the MongoDB backend

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/323/ for more details.

aeviso requested review of this revision.Tue, Sep 7, 4:56 PM
  • Remove autocommit isolation level from ProvenanceStoragePostgreSql

Build is green

Patch application report for D6209 (id=22492)

Rebasing onto 26061a0a15...

Current branch diff-target is up to date.
Changes applied before test
commit 4c2b0907a93783a2291a02bf71104dc39d8675e9
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Wed Sep 8 16:36:50 2021 +0200

    Remove autocommit isolation level from `ProvenanceStoragePostgreSql`
    
    Transactions are now managed explicitly by each method in the class

commit 73dd6cb447739fd0b0f43f1eea73b7f763e4e927
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Tue Sep 7 15:46:20 2021 +0200

    Remove locks from PostgreSQL backend insertions

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/325/ for more details.

This revision is now accepted and ready to land.Wed, Sep 8, 6:35 PM