Details

Reviewers

olasd

Group Reviewers

System administrators

Commits

rSPSITE089b64ba3921: Update scheduler metrics every 4 hours

Summary

This triggers exactly every 4 hours but not on round timestamps.

Test Plan

octo-diff: on scheduler nodes (saatchi, scheduler0.staging), the period is increased
accordingly:

*******************************************
  Systemd::Timer[swh-scheduler-update-metrics.timer] =>
   parameters =>
     timer_content =>
      @@ -3,6 +3,8 @@
      _
       [Timer]
      -OnCalendar=daily
       Unit=swh-scheduler-update-metrics.service
      +OnCalendar=00/4:00
      +RandomizedDelaySec=1h
      +FixedRandomDelay=true
      _
       [Unit]
*******************************************
  Systemd::Unit_file[swh-scheduler-update-metrics.timer] =>
   parameters =>
     content =>
      @@ -3,6 +3,8 @@
      _
       [Timer]
      -OnCalendar=daily
       Unit=swh-scheduler-update-metrics.service
      +OnCalendar=00/4:00
      +RandomizedDelaySec=1h
      +FixedRandomDelay=true
      _
       [Unit]
*******************************************

Diff Detail

Repository

rSPSITE puppet-swh-site

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont requested review of this revision.Aug 30 2021, 12:12 PM

ardumont created this revision.

Harbormaster completed remote builds in B23260: Diff 22304.Aug 30 2021, 12:12 PM

Simplify query

Harbormaster completed remote builds in B23261: Diff 22305.Aug 30 2021, 12:13 PM

ardumont edited the test plan for this revision. (Show Details)Aug 30 2021, 12:17 PM

I'll try to randomize this a bit more.

site-modules/profile/templates/swh/deploy/scheduler/swh-scheduler-update-metrics.timer.erb
4–5	as olasd suggested to me.

Ensure the timer executes roughly every 4h

Harbormaster completed remote builds in B23264: Diff 22308.Aug 30 2021, 2:29 PM

ardumont edited the test plan for this revision. (Show Details)Aug 30 2021, 2:34 PM

ardumont retitled this revision from Update scheduler metrics every 4 hours to Update scheduler metrics every ~4 hours.

What about FixedRandomDelay=true ? I think it makes sense to have this running every four hours exactly, rather than every 4 hours +/- 1 hour.

This revision is now accepted and ready to land.Aug 30 2021, 2:41 PM

Use fixed randomness

Harbormaster completed remote builds in B23265: Diff 22309.Aug 30 2021, 2:55 PM

ardumont edited the test plan for this revision. (Show Details)Aug 30 2021, 2:56 PM

Use correct repository for diffing.

Harbormaster completed remote builds in B23266: Diff 22310.Aug 30 2021, 2:56 PM

ardumont retitled this revision from Update scheduler metrics every ~4 hours to Update scheduler metrics every 4 hours.Aug 30 2021, 2:59 PM

ardumont edited the summary of this revision. (Show Details)

olasd accepted this revision.Aug 30 2021, 3:23 PM

Rebase

Harbormaster completed remote builds in B23267: Diff 22311.Aug 30 2021, 3:25 PM

Closed by commit rSPSITE089b64ba3921: Update scheduler metrics every 4 hours (authored by ardumont). · Explain WhyAug 30 2021, 3:26 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rSPSITE089b64ba3921: Update scheduler metrics every 4 hours.

Update scheduler metrics every 4 hours
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 22312

site-modules/profile/templates/swh/deploy/scheduler/swh-scheduler-update-metrics.timer.erb

Update scheduler metrics every 4 hoursClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 22312

site-modules/profile/templates/swh/deploy/scheduler/swh-scheduler-update-metrics.timer.erb

Update scheduler metrics every 4 hours
ClosedPublic
Actions

Revision Contents
Changeset List