Page MenuHomeSoftware Heritage

Add a tox file and fix flake8 errors
ClosedPublic

Authored by douardda on Oct 25 2018, 5:47 PM.

Diff Detail

Repository
rDLS Listers
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont added a subscriber: ardumont.

Funny, I thought that this module needed a db for its tests to pass.

Note:

  • Don't you want to also migrate to pytest as well (sed 's/nose/pytest' -i requirements-test.txt)?
  • for information, tests are green but warnings pop up in the end (tox, make test with pytest)
Exception during reset or similar
Traceback (most recent call last):
  File "/home/tony/work/inria/repo/swh/swh-environment/.venv/lib/python3.6/site-packages/sqlalchemy/pool.py", line 709, in _finalize_fairy
    fairy._reset(pool)
  File "/home/tony/work/inria/repo/swh/swh-environment/.venv/lib/python3.6/site-packages/sqlalchemy/pool.py", line 880, in _reset
    pool._dialect.do_rollback(self)
  File "/home/tony/work/inria/repo/swh/swh-environment/.venv/lib/python3.6/site-packages/sqlalchemy/engine/default.py", line 459, in do_rollback
    dbapi_connection.rollback()
psycopg2.OperationalError: terminating connection due to administrator command
server closed the connection unexpectedly
        This probably means the server terminated abnormally
        before or while processing the request.
This revision is now accepted and ready to land.Oct 25 2018, 6:12 PM

add a commit to kill remaining nose whims to be around

This revision was automatically updated to reflect the committed changes.