Page MenuHomeSoftware Heritage
Differential D597

tests: migrate to pytest
ClosedPublic
Actions

Authored by douardda on Oct 25 2018, 1:40 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Summary

related to T1261.

Also add a tox file

related to T1247.

Test Plan

pytest should pass (via pifpaf if no pg is running)
but for now I have a few tests that fail (test_origin_metadata.py)

Diff Detail

Repository
rDCIDX Metadata indexer
Branch
pytest
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1914
Build 2304: arc lint + arc unit

Event Timeline

douardda created this revision.Oct 25 2018, 1:40 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 25 2018, 1:40 PM
Harbormaster completed remote builds in B1905: Diff 1820.Oct 25 2018, 1:40 PM
ardumont requested changes to this revision.Oct 25 2018, 1:58 PM
ardumont added a subscriber: ardumont.
ardumont added inline comments.
pytest.ini
3 ↗(On Diff #1820)

Why django?
The swh-indexer does not use django (only swh-deposit and swh-web do ;)

requirements-test.txt
1

same.

This revision now requires changes to proceed.Oct 25 2018, 1:58 PM
douardda added inline comments.Oct 25 2018, 2:02 PM
pytest.ini
3 ↗(On Diff #1820)

because without it, I have most of the tests that fail with django.core.exceptions.ImproperlyConfigured errors

douardda marked 2 inline comments as done.Oct 25 2018, 2:08 PM
douardda added inline comments.
pytest.ini
3 ↗(On Diff #1820)

forget it, don't know what I did, but I messed up

ardumont added inline comments.Oct 25 2018, 2:22 PM
pytest.ini
3 ↗(On Diff #1820)

is it possible you:

  • copied from swh-deposit that pytest.ini?
  • t run tox ~> it then complained about django.
  • then you added the pytest-django to make it happy ;)

?

douardda updated this revision to Diff 1833.Oct 25 2018, 3:53 PM
douardda marked an inline comment as done.

rebase and address silly my django stuff

Harbormaster completed remote builds in B1914: Diff 1833.Oct 25 2018, 3:53 PM
ardumont accepted this revision.Oct 25 2018, 4:03 PM
This revision is now accepted and ready to land.Oct 25 2018, 4:03 PM
douardda closed this revision.Oct 25 2018, 5:21 PM

closed by 00145f6ae55a2d9e03193714ce3f37fe84b3e07c

Revision Contents
Changeset List

PathSize
1 line
2 lines
swh/
indexer/
tests/
storage/
3 lines
7 lines
6 lines
8 lines
17 lines

Diff 1833

View Options

.gitignore

Loading...
View Options

requirements-test.txt

Loading...
View Options

swh/indexer/tests/storage/test_converters.py

Loading...
View Options

swh/indexer/tests/storage/test_storage.py

Loading...
View Options

swh/indexer/tests/test_origin_head.py

Loading...
View Options

swh/indexer/tests/test_origin_metadata.py

Loading...
View Options

tox.ini

Loading...
About · Developer information · Legal