Remove CMDBTS based tests
ClosedPublic
Actions

Authored by douardda on Jun 4 2021, 3:44 PM.

Details

Reviewers

Group Reviewers

Commits

rDPROV100384fb8f14: Remove test_provenance_add_revision
rDPROVb73d7ff823be: Parametrize the archive() test fixture to test both Archive implementations
rDPROV4138c61740d2: Remove the CMDBTS based test_provenance_content_find_all

Summary

remove test_provenance_content_find_all(), now we have the new version of this in test_provenance_heuristics.py.

Also test this later with an ArchiveStorage in addition to the default ArchivePostgreSQL class.

Parametrize the archive() test fixture to test both Archive implementations aka. both the ArchiveStorage ans the ArchivePostgreSQL ones.

Remove test_provenance_add_revision it's superseeded by test_provenance_heuristics.

Diff Detail

Repository

rDPROV Provenance database

Branch

wip

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 21785
Build 33873: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 33872: arc lint + arc unit

Event Timeline

douardda created this revision.Jun 4 2021, 3:44 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 4 2021, 3:44 PM

Build is green

Patch application report for D5821 (id=20826)

Rebasing onto f64a41b6ee...

Current branch diff-target is up to date.

Changes applied before test

commit 100384fb8f148e5d42489264cde783cd18e59862
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jun 4 11:43:24 2021 +0200

    Remove test_provenance_add_revision
    
    it's superseeded by test_provenance_heuristics.

commit b73d7ff823bee5c69bfbfb113df7b0d575bbf289
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jun 4 10:50:06 2021 +0200

    Parametrize the archive() test fixture to test both Archive implementations
    
    aka. both the ArchiveStorage ans the ArchivePostgreSQL ones.

commit 4138c61740d2a4771613ead0e1cf529e37c7d239
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jun 4 10:38:55 2021 +0200

    Remove the CMDBTS based test_provenance_content_find_all
    
    now we have the new version of this in test_provenance_heuristics.py.
    
    Also test this later with an ArchiveStorage in addition to the default
    ArchivePostgreSQL class.

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/88/ for more details.

Harbormaster completed remote builds in B21785: Diff 20826.Jun 4 2021, 3:45 PM

douardda requested review of this revision.Jun 4 2021, 3:45 PM

aeviso accepted this revision.Jun 4 2021, 4:28 PM

This revision is now accepted and ready to land.Jun 4 2021, 4:28 PM

Closed by commit rDPROV4138c61740d2: Remove the CMDBTS based test_provenance_content_find_all (authored by douardda). · Explain WhyJun 7 2021, 10:12 AM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDPROV4138c61740d2: Remove the CMDBTS based test_provenance_content_find_all.

douardda added a commit: rDPROVb73d7ff823be: Parametrize the archive() test fixture to test both Archive implementations.

douardda added a commit: rDPROV100384fb8f14: Remove test_provenance_add_revision.