Page MenuHomeSoftware Heritage
Differential D581

swh.objstorage: Migrate to latest swh.model.hashutil.MultiHash
ClosedPublic
Actions

Authored by ardumont on Oct 23 2018, 6:54 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Commits
rDOBJSf6a80579c02a: requirements: Bump to latest dependency
rDOBJS7ecba0f5a934: swh.objstorage: Migrate to latest swh.model.hashutil.MultiHash
Summary

Remove redundant calls in tests

requirements: Bump to latest dependency

Diff Detail

Repository
rDOBJS Object storage
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Oct 23 2018, 6:54 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 23 2018, 6:54 PM
ardumont marked an inline comment as done.Oct 23 2018, 7:02 PM
ardumont added inline comments.
swh/objstorage/objstorage_pathslicing.py
260

I'm wondering if we should not remove that block.
And add that back the day we actually need it.

context: ID_HASH_ALGO is sha1 from the start... so we never went through that if block

ardumont edited the summary of this revision. (Show Details)Oct 24 2018, 10:49 AM
ardumont edited the summary of this revision. (Show Details)Oct 24 2018, 10:51 AM
olasd accepted this revision.Oct 24 2018, 11:11 AM
olasd added a subscriber: olasd.
olasd added inline comments.
swh/objstorage/objstorage_pathslicing.py
260

Ideally we'd test an objstorage with a different ID_HASH_ALGO, but I agree that the usefulness of supporting git-style hashes is very limited.

This revision is now accepted and ready to land.Oct 24 2018, 11:11 AM
Closed by commit rDOBJS7ecba0f5a934: swh.objstorage: Migrate to latest swh.model.hashutil.MultiHash (authored by ardumont). · Explain WhyOct 24 2018, 11:37 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
objstorage/
18 lines
6 lines
tests/
6 lines
11 lines

Diff 1789

View Options

swh/objstorage/objstorage.py

Loading...
View Options

swh/objstorage/objstorage_pathslicing.py

Loading...
View Options

swh/objstorage/tests/objstorage_testing.py

Loading...
View Options

swh/objstorage/tests/test_multiplexer_filter.py

Loading...
About · Developer information · Legal