Differential D5768

client: Add more coverage and types
ClosedPublic
Actions

Authored by ardumont on May 24 2021, 10:23 AM.

Details

Reviewers

None

Group Reviewers

Reviewers

Maniphest Tasks

T2996: Add possibility to fetch a list of deposits on the deposit cli

Commits

rDDEP63c1bc3e0d1f: swh/deposit/client: Add more coverage and types

Summary

This renames some variables with more meaningful names. This also fixes some mistyped
methods.

Related to T2996

(to check jenkins coverage)

Test Plan

tox

Diff Detail

Repository

rDDEP Push deposit

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.May 24 2021, 10:23 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 24 2021, 10:23 AM

ardumont edited the summary of this revision. (Show Details)May 24 2021, 10:23 AM

Build is green

Patch application report for D5768 (id=20627)

Rebasing onto c28bb48669...

Current branch diff-target is up to date.

Changes applied before test

commit 13a2cc38d31d6cdbdb54dd423f865d54dfe37571
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon May 24 10:18:57 2021 +0200

    swh/deposit/client: Rename variables with meaningful names
    
    This also introduces some more types and fix existing ones.
    
    Related to T2996

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/653/ for more details.

Harbormaster completed remote builds in B21591: Diff 20627.May 24 2021, 10:27 AM

ardumont requested review of this revision.May 24 2021, 10:27 AM

Add more types

Build is green

Patch application report for D5768 (id=20628)

Rebasing onto c28bb48669...

Current branch diff-target is up to date.

Changes applied before test

commit 34a062748d268469dcd943be664734376a293713
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon May 24 10:18:57 2021 +0200

    swh/deposit/client: Rename variables with meaningful names
    
    This also introduces some more types and fix existing ones.
    
    Related to T2996

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/654/ for more details.

Harbormaster completed remote builds in B21592: Diff 20628.May 24 2021, 10:39 AM

ardumont retitled this revision from swh/deposit/client: Rename variables with meaningful names to swh/deposit/client: Add more coverage and types.May 24 2021, 11:29 AM

ardumont edited the summary of this revision. (Show Details)

Add coverage on the missing parts (the BaseDepositClient.execute method)

Build is green

Patch application report for D5768 (id=20629)

Rebasing onto c28bb48669...

Current branch diff-target is up to date.

Changes applied before test

commit 63c1bc3e0d1f0d7a46c7ce68c5075ab9ba24158d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon May 24 10:18:57 2021 +0200

    swh/deposit/client: Add more coverage and types
    
    This renames some variables with more meaningful names. This also fixes some mistyped
    methods.
    
    Related to T2996

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/655/ for more details.

Harbormaster completed remote builds in B21593: Diff 20629.May 24 2021, 11:35 AM

This revision was not accepted when it landed; it landed in state Needs Review.May 24 2021, 3:52 PM

Closed by commit rDDEP63c1bc3e0d1f: swh/deposit/client: Add more coverage and types (authored by ardumont). · Explain Why

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDDEP63c1bc3e0d1f: swh/deposit/client: Add more coverage and types.