swh-loader-dir: Add tox.ini and migrate to pytest
ClosedPublic
Actions

Authored by ardumont on Oct 23 2018, 1:29 PM.

Details

Reviewers

Commits

rDLDDIRb39849d695f7: tests: Add tox.ini file
rDLDDIR3c593a075938: tests: Migrate to pytest
rDLDDIRbaf86522b06e: tests: Remove deprecation warnings

Summary

Also fix warnings

Depends D566
Related T1247
Related T1261

Test Plan

tox
fails for now as it needs swh-loader-core bump (after D566 merge)

Diff Detail

Repository

rDLDDIR Directory Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Oct 23 2018, 1:29 PM

Harbormaster failed remote builds in B1761: Diff 1750!Oct 23 2018, 1:30 PM

Build failing with the same setup issue as D566 (loader-core), due to setup issue in swh-jenkins-jobs.

Digging the logs:

stderr: fatal: repository 'https://forge.softwareheritage.org/source/loader-dir.git/' not found

Should be swh-loader-dir.git.
Fix: change the display-name from loader-dir to swh-loader-dir in swh-jenkins-jobs/swh/loader-dir.yml
(it's there now \m/ [1])

[1] R155:c5cd557e7a1b68667780452e7d7cb3742880b641

same as others: tests depends on swh-loader-core > 0.0.34

This revision is now accepted and ready to land.Oct 23 2018, 2:48 PM

Closed by commit rDLDDIRbaf86522b06e: tests: Remove deprecation warnings (authored by ardumont). · Explain WhyOct 23 2018, 3:56 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

loader/

dir/

tests/

test_converters.py

14 lines

test_loader.py

31 lines

Diff 1766

View Options

swh/loader/dir/tests/test_converters.py