Differential D543

sql: move sql files in the python package and refactor tests to use these according to D538
ClosedPublic
Actions

Authored by douardda on Oct 16 2018, 11:24 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T1265: kill swh-storage-testdata [was: make swh-storage-testdata a python package]

Commits

rDCIDX94b16d05b7c0: packaging: bump dep to swh-core v0.0.44
rDCIDX526a5b973e35: sql: move sql files in the python package and refactor tests to use these

Summary

This requires a few steps:

refactor the BaseTestStorage to use SingleDbTestFixture
rename any swh-xxx.sql files into NN-swh-xxx.sql so we can sort them without ambiguity
move them into the python package, so the tests knows where to look for them.

Related to T1265.

Test Plan

all tests should pass if D538 is applied to swh-core

Diff Detail

Repository

rDCIDX Metadata indexer

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Oct 16 2018, 11:24 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 16 2018, 11:24 PM

Harbormaster completed remote builds in B1668: Diff 1669.Oct 16 2018, 11:24 PM

ardumont accepted this revision.Oct 17 2018, 11:37 AM

This revision is now accepted and ready to land.Oct 17 2018, 11:37 AM

regroup both requirements and debian deps bump in a single commit

Harbormaster completed remote builds in B1674: Diff 1681.Oct 17 2018, 4:18 PM

Closed by commit rDCIDX526a5b973e35: sql: move sql files in the python package and refactor tests to use these (authored by douardda). · Explain WhyOct 17 2018, 4:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

MANIFEST.in

3 lines

sql/

	swh/	indexer/	sql/
			sql/

	10-swh-init.sql
	swh-init.sql

	20-swh-enums.sql
	swh-enums.sql

	30-swh-schema.sql
	swh-schema.sql

	40-swh-func.sql
	swh-func.sql

	50-swh-data.sql
	swh-data.sql

	60-swh-indexes.sql
	swh-indexes.sql

swh/

indexer/

tests/

__init__.py

5 lines

data/

dumps/

swh-indexer.sql

storage/

test_api_client.py

2 lines

test_storage.py

64 lines

Diff 1682

View Options

MANIFEST.in

View Options

sql/Makefile

View Options

sql/swh-data.sql

View Options

sql/swh-enums.sql

View Options

sql/swh-func.sql

View Options

sql/swh-indexes.sql

View Options

sql/swh-init.sql

View Options

sql/swh-schema.sql

View Options

swh/indexer/sql/10-swh-init.sql

View Options

swh/indexer/sql/20-swh-enums.sql

View Options

swh/indexer/sql/30-swh-schema.sql

View Options

swh/indexer/sql/40-swh-func.sql

View Options

swh/indexer/sql/50-swh-data.sql

View Options

swh/indexer/sql/60-swh-indexes.sql

View Options

swh/indexer/tests/init.py

View Options

swh/indexer/tests/data/dumps/swh-indexer.sql

View Options

swh/indexer/tests/storage/test_api_client.py

View Options

swh/indexer/tests/storage/test_storage.py

sql: move sql files in the python package and refactor tests to use these according to D538ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1682

MANIFEST.in

sql/Makefile

sql/swh-data.sql

sql/swh-enums.sql

sql/swh-func.sql

sql/swh-indexes.sql

sql/swh-init.sql

sql/swh-schema.sql

swh/indexer/sql/10-swh-init.sql

swh/indexer/sql/20-swh-enums.sql

swh/indexer/sql/30-swh-schema.sql

swh/indexer/sql/40-swh-func.sql

swh/indexer/sql/50-swh-data.sql

swh/indexer/sql/60-swh-indexes.sql

swh/indexer/tests/__init__.py

swh/indexer/tests/data/dumps/swh-indexer.sql

swh/indexer/tests/storage/test_api_client.py

swh/indexer/tests/storage/test_storage.py

sql: move sql files in the python package and refactor tests to use these according to D538
ClosedPublic
Actions

Revision Contents
Changeset List

swh/indexer/tests/init.py