Page MenuHomeSoftware Heritage
Differential D5253

Implement remote service
ClosedPublic
Actions

Authored by vsellier on Mar 15 2021, 8:04 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
T2912: Next generation archive counters
Commits
rDCNTd88278619db7: Implement remote service
Summary

Related to T2912

Diff Detail

Repository
rDCNT Archive counters
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vsellier created this revision.Mar 15 2021, 8:04 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 15 2021, 8:04 PM
swh-public-ci added a comment.Mar 15 2021, 8:05 PM

Build is green

Patch application report for D5253 (id=18836)

Rebasing onto d90ee19746...

Current branch diff-target is up to date.
Changes applied before test
commit f31840db2a323e2bd51d8611370761401cfcb9d0
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Mon Mar 15 17:50:41 2021 +0100

    Implement remote service
    
    Related to T2912

See https://jenkins.softwareheritage.org/job/DCNT/job/tests-on-diff/11/ for more details.

Harbormaster completed remote builds in B19929: Diff 18836.Mar 15 2021, 8:05 PM
vsellier requested review of this revision.Mar 15 2021, 8:05 PM
vsellier planned changes to this revision.Mar 16 2021, 9:47 AM

changing status to pending changes as I will reworke the app initialization to use the same method as swh-objstorage

vsellier updated this revision to Diff 18844.Mar 16 2021, 1:02 PM

Change the flask app implementation method

swh-public-ci added a comment.Mar 16 2021, 1:03 PM

Build is green

Patch application report for D5253 (id=18844)

Rebasing onto d90ee19746...

Current branch diff-target is up to date.
Changes applied before test
commit 8c986704a30199e4a9eca0b3286530cf46bae69d
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Mon Mar 15 17:50:41 2021 +0100

    Implement remote service
    
    Related to T2912

See https://jenkins.softwareheritage.org/job/DCNT/job/tests-on-diff/12/ for more details.

Harbormaster completed remote builds in B19939: Diff 18844.Mar 16 2021, 1:03 PM
ardumont accepted this revision.Mar 16 2021, 1:40 PM
ardumont added a subscriber: ardumont.

lgtm

one remark inline.

swh/counters/tests/test_server.py
18

as api_cfg is no longer defined.

This revision is now accepted and ready to land.Mar 16 2021, 1:40 PM
vsellier updated this revision to Diff 18850.Mar 16 2021, 4:05 PM

fix tear down method

swh-public-ci added a comment.Mar 16 2021, 4:07 PM

Build is green

Patch application report for D5253 (id=18850)

Rebasing onto d90ee19746...

Current branch diff-target is up to date.
Changes applied before test
commit d88278619db703a3bde6c729f89cdfada600cc40
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Mon Mar 15 17:50:41 2021 +0100

    Implement remote service
    
    Related to T2912

See https://jenkins.softwareheritage.org/job/DCNT/job/tests-on-diff/13/ for more details.

Harbormaster completed remote builds in B19944: Diff 18850.Mar 16 2021, 4:07 PM
Closed by commit rDCNTd88278619db7: Implement remote service (authored by vsellier). · Explain WhyMar 16 2021, 6:34 PM
This revision was automatically updated to reflect the committed changes.
vsellier added a commit: rDCNTd88278619db7: Implement remote service.

Revision Contents
Changeset List

PathSize
swh/
counters/
api/
86 lines
2 lines
tests/
99 lines

Diff 18855

View Options

swh/counters/api/server.py

Loading...
View Options

swh/counters/interface.py

Loading...
View Options

swh/counters/tests/test_server.py

Loading...
About · Developer information · Legal