Page MenuHomeSoftware Heritage
Differential D515

Fix confusing name (destination_queue/destination_task is a task name, not a queue name).
ClosedPublic
Actions

Authored by vlorentz on Oct 11 2018, 2:59 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDCIDX3b0625127ab1: Fix confusing name (destination_queue/destination_task is a task name, not a…

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Oct 11 2018, 2:59 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 11 2018, 2:59 PM
Harbormaster completed remote builds in B1627: Diff 1609.Oct 11 2018, 2:59 PM
ardumont accepted this revision.Oct 11 2018, 3:19 PM

Right.

For your information, this impacts the deployment [1]

[1] https://forge.softwareheritage.org/source/puppet-swh-site/browse/production/data/defaults.yaml$1973

swh/indexer/mimetype.py
59

lol, this now makes my eyes blink more than needed...

self.task_destination = destination_task...

I think we should align those.

This revision is now accepted and ready to land.Oct 11 2018, 3:19 PM
vlorentz updated this revision to Diff 1612.Oct 11 2018, 3:30 PM
  • s/task_destination/destination_task/
Harbormaster completed remote builds in B1630: Diff 1612.Oct 11 2018, 3:30 PM
vlorentz updated this revision to Diff 1614.Oct 11 2018, 5:25 PM
This comment was removed by vlorentz.
Harbormaster completed remote builds in B1631: Diff 1614.Oct 11 2018, 5:25 PM
vlorentz updated this revision to Diff 1615.Oct 11 2018, 5:26 PM
This comment was removed by vlorentz.
Harbormaster completed remote builds in B1632: Diff 1615.Oct 11 2018, 5:26 PM
Closed by commit rDCIDX3b0625127ab1: Fix confusing name (destination_queue/destination_task is a task name, not a… (authored by vlorentz). · Explain WhyOct 11 2018, 5:27 PM
This revision was automatically updated to reflect the committed changes.
ardumont added inline comments.Oct 11 2018, 5:43 PM
swh/indexer/tests/test_mimetype.py
50

That becomes useless ;)

Revision Contents
Changeset List

PathSize
docs/
2 lines
swh/
indexer/
14 lines
tests/
4 lines
4 lines
6 lines

Diff 1616

View Options

docs/dev-info.rst

Loading...
View Options

swh/indexer/mimetype.py

Loading...
View Options

swh/indexer/tests/test_language.py

Loading...
View Options

swh/indexer/tests/test_metadata.py

Loading...
View Options

swh/indexer/tests/test_mimetype.py

Loading...
About · Developer information · Legal