Page MenuHomeSoftware Heritage

Don't update Mercurial repositories after cloning
ClosedPublic

Authored by Alphare on Feb 25 2021, 12:00 PM.

Details

Summary

By default, Mercurial updates to the default revision after cloning,
which - while probably good UX - is wasteful in the context of automated
archival and server-side operations.

Diff Detail

Repository
rDLDHG Mercurial loader
Branch
no-update
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19460
Build 30191: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 30190: arc lint + arc unit

Unit TestsFailed

TimeTest
97 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.mercurial.tests.test_hgutil::test_clone_timeout
monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x7f94ac53cc18> def test_clone_timeout(monkeypatch):
37 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.mercurial.tests.test_loader::test_clone_with_timeout_exception
caplog = <_pytest.logging.LogCaptureFixture object at 0x7f94ac488a90> tmp_path = PosixPath('/tmp/pytest-of-jenkins/pytest-0/test_clone_with_timeout_except0') monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x7f94ac488cc0>
37 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.mercurial.tests.test_loader::test_clone_with_timeout_returns
caplog = <_pytest.logging.LogCaptureFixture object at 0x7f94ac5f1198> tmp_path = PosixPath('/tmp/pytest-of-jenkins/pytest-0/test_clone_with_timeout_return0') monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x7f94ac5f1358>
37 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.mercurial.tests.test_loader::test_clone_with_timeout_timeout
caplog = <_pytest.logging.LogCaptureFixture object at 0x7f94ac594c88> tmp_path = PosixPath('/tmp/pytest-of-jenkins/pytest-0/test_clone_with_timeout_timeou0') monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x7f94ac4ce7f0>
2 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.mercurial.tests.test_converters.TestParseAuthorConverters::test_parse_author_2
View Full Test Results (4 Failed · 39 Passed)

Event Timeline

Build has FAILED

Patch application report for D5141 (id=18382)

Rebasing onto d8572187e9...

First, rewinding head to replay your work on top of it...
Applying: Don't update Mercurial repositories after cloning
Changes applied before test
commit bcecc967a5a2938dc88ef00aff84e4b63ef3e318
Author: Raphaël Gomès <rgomes@octobus.net>
Date:   Thu Feb 25 11:54:36 2021 +0100

    Don't update Mercurial repositories after cloning
    
    By default, Mercurial updates to the default revision after cloning,
    which - while probably good UX - is wasteful in the context of automated
    archival and server-side operations.

Link to build: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/163/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/163/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 25 2021, 12:01 PM
Harbormaster failed remote builds in B19460: Diff 18382!

Build is green

Patch application report for D5141 (id=18385)

Rebasing onto d8572187e9...

First, rewinding head to replay your work on top of it...
Applying: Don't update Mercurial repositories after cloning
Changes applied before test
commit 800e5378bfa101f61af83c5dcb3b825fd89ea680
Author: Raphaël Gomès <rgomes@octobus.net>
Date:   Thu Feb 25 11:54:36 2021 +0100

    Don't update Mercurial repositories after cloning
    
    By default, Mercurial updates to the default revision after cloning,
    which - while probably good UX - is wasteful in the context of automated
    archival and server-side operations.

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/164/ for more details.

ardumont added a subscriber: ardumont.

lgtm

please note the remarks on missing copyright headers

swh/loader/mercurial/tests/test_hgutil.py
1 ↗(On Diff #18385)

-2021

Please also update and add the copyright header where missing (in the files you are touching).

This revision is now accepted and ready to land.Feb 25 2021, 12:29 PM

Build is green

Patch application report for D5141 (id=18407)

Rebasing onto d8572187e9...

First, rewinding head to replay your work on top of it...
Applying: Don't update Mercurial repositories after cloning
Changes applied before test
commit 4be2253ff3b5c6e30c9480e9747f3dd92dc39f58
Author: Raphaël Gomès <rgomes@octobus.net>
Date:   Thu Feb 25 11:54:36 2021 +0100

    Don't update Mercurial repositories after cloning
    
    By default, Mercurial updates to the default revision after cloning,
    which - while probably good UX - is wasteful in the context of automated
    archival and server-side operations.

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/166/ for more details.

Build is green

Patch application report for D5141 (id=18428)

Rebasing onto d8572187e9...

Current branch diff-target is up to date.
Changes applied before test
commit 1dbb8474ad0a1a6e7cc8d52fcb487bd8a37659c6
Author: Raphaël Gomès <rgomes@octobus.net>
Date:   Thu Feb 25 11:54:36 2021 +0100

    Don't update Mercurial repositories after cloning
    
    By default, Mercurial updates to the default revision after cloning,
    which - while probably good UX - is wasteful in the context of automated
    archival and server-side operations.

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/171/ for more details.