Page MenuHomeSoftware Heritage

Add SWHID badges in doc examples
AbandonedPublic

Authored by vlorentz on Feb 24 2021, 8:41 AM.

Details

Reviewers
KShivendu
Group Reviewers
Reviewers
Summary

Fix for T2159

Diff Detail

Repository
rDMOD Data model
Branch
swhid-badge-doc-examples
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19445
Build 30164: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 30163: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D5135 (id=18367)

Rebasing onto 758eb885d3...

Current branch diff-target is up to date.
Changes applied before test
commit dfbff28d40837feed882f3fb0bf9ada2b374e328
Author: KShivendu <shivendu@iitbhilai.ac.in>
Date:   Wed Feb 24 13:10:13 2021 +0530

    Add SWHID badges in doc examples

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/264/ for more details.

Hi,

Thanks for the diff.

Links don't work because the text in :target: is made part of the URL.
The alt text in the generated HTML is also incorrect, as it is the URL instead of being the SWHID

And IMO, we shouldn't replace the text with badges, because badges are not copy-pastable

This revision now requires changes to proceed.Feb 26 2021, 8:47 AM
vlorentz abandoned this revision.
vlorentz edited reviewers, added: KShivendu; removed: vlorentz.

Closing this due to inactivity