Differential D5115

mapping_utils: Define AUTHORITY and FETCHER properly instead of evolving them in every single use.
ClosedPublic
Actions

Authored by vlorentz on Feb 19 2021, 10:42 AM.

Details

Reviewers

TG1999

Commits

rDMFCD429ca5f59bbb: mapping_utils: Define AUTHORITY and FETCHER properly instead of evolving them…

Diff Detail

Repository

rDMFCD ClearlyDefined metadata fetcher

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Feb 19 2021, 10:42 AM

Build has FAILED

Patch application report for D5115 (id=18287)

Could not rebase; Attempt merge onto 10e3919718...

Updating 10e3919..73f6e24
Fast-forward
 swh/clearlydefined/mapping_utils.py            | 32 +++++++++----------
 swh/clearlydefined/tests/test_mapping_utils.py | 44 +++++++++++++-------------
 2 files changed, 38 insertions(+), 38 deletions(-)

Changes applied before test

commit 73f6e24d027ecfca4e7e2400fd97750b71ba5b32
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Feb 19 10:41:37 2021 +0100

    mapping_utils: Define AUTHORITY and FETCHER properly instead of evolving them in every single use.

commit cbd628877406240488d3c3931a4a60e228bf62f6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Feb 19 10:39:24 2021 +0100

    mapping_utils: define constants in uppercase and at the beginning of the file
    
    https://www.python.org/dev/peps/pep-0008/#constants

Link to build: https://jenkins.softwareheritage.org/job/DMFCD/job/tests-on-diff/106/
See console output for more information: https://jenkins.softwareheritage.org/job/DMFCD/job/tests-on-diff/106/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 19 2021, 10:42 AM

Harbormaster failed remote builds in B19373: Diff 18287!

fix flake8 warnings (no need to import attr anymore)

Build is green

Patch application report for D5115 (id=18288)

Could not rebase; Attempt merge onto 10e3919718...

Updating 10e3919..429ca5f
Fast-forward
 swh/clearlydefined/mapping_utils.py            | 34 +++++++++----------
 swh/clearlydefined/tests/test_mapping_utils.py | 45 +++++++++++++-------------
 2 files changed, 38 insertions(+), 41 deletions(-)

Changes applied before test

commit 429ca5f59bbb93634a843f6d5566e52cb2109e05
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Feb 19 10:41:37 2021 +0100

    mapping_utils: Define AUTHORITY and FETCHER properly instead of evolving them in every single use.

commit cbd628877406240488d3c3931a4a60e228bf62f6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Feb 19 10:39:24 2021 +0100

    mapping_utils: define constants in uppercase and at the beginning of the file
    
    https://www.python.org/dev/peps/pep-0008/#constants

See https://jenkins.softwareheritage.org/job/DMFCD/job/tests-on-diff/107/ for more details.

Harbormaster completed remote builds in B19374: Diff 18288.Feb 19 2021, 10:46 AM

vlorentz requested review of this revision.Feb 19 2021, 10:46 AM

TG1999 accepted this revision.Feb 19 2021, 11:51 AM

This revision is now accepted and ready to land.Feb 19 2021, 11:51 AM

Closed by commit rDMFCD429ca5f59bbb: mapping_utils: Define AUTHORITY and FETCHER properly instead of evolving them… (authored by vlorentz). · Explain WhyFeb 19 2021, 12:59 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDMFCD429ca5f59bbb: mapping_utils: Define AUTHORITY and FETCHER properly instead of evolving them….