Differential D5114

mapping_utils: define constants in uppercase and at the beginning of the file
ClosedPublic
Actions

Authored by vlorentz on Feb 19 2021, 10:39 AM.

Details

Reviewers

TG1999

Commits

rDMFCDcbd628877406: mapping_utils: define constants in uppercase and at the beginning of the file

Summary

https://www.python.org/dev/peps/pep-0008/#constants

Diff Detail

Repository

rDMFCD ClearlyDefined metadata fetcher

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Feb 19 2021, 10:39 AM

Build is green

Patch application report for D5114 (id=18286)

Rebasing onto 10e3919718...

Current branch diff-target is up to date.

Changes applied before test

commit cbd628877406240488d3c3931a4a60e228bf62f6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Feb 19 10:39:24 2021 +0100

    mapping_utils: define constants in uppercase and at the beginning of the file
    
    https://www.python.org/dev/peps/pep-0008/#constants

See https://jenkins.softwareheritage.org/job/DMFCD/job/tests-on-diff/105/ for more details.

Harbormaster completed remote builds in B19372: Diff 18286.Feb 19 2021, 10:40 AM

vlorentz requested review of this revision.Feb 19 2021, 10:40 AM

TG1999 accepted this revision.Feb 19 2021, 12:58 PM

This revision is now accepted and ready to land.Feb 19 2021, 12:58 PM

Closed by commit rDMFCDcbd628877406: mapping_utils: define constants in uppercase and at the beginning of the file (authored by vlorentz). · Explain WhyFeb 19 2021, 12:59 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDMFCDcbd628877406: mapping_utils: define constants in uppercase and at the beginning of the file.