Differential D5074

mercurial.loader: Make error comparison case-insensitive
ClosedPublic
Actions

Authored by ardumont on Feb 15 2021, 4:59 PM.

Details

Reviewers

vsellier

Group Reviewers

Reviewers

Commits

rDLDHG71cfd100180f: mercurial.loader: Make error comparison case-insensitive

Summary

This avoids failing visits for the wrong comparison check [1]

[1] https://sentry.softwareheritage.org/share/issue/27017710a5ec49f991910a780d38d4ab/

Diff Detail

Repository

rDLDHG Mercurial loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Feb 15 2021, 4:59 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 15 2021, 4:59 PM

Build is green

Patch application report for D5074 (id=18110)

Rebasing onto 4c84a86b37...

Current branch diff-target is up to date.

Changes applied before test

commit 71cfd100180fcd65e0ef3996fdf6a0e753d5a7f9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Feb 15 16:51:40 2021 +0100

    mercurial.loader: Make error comparison case-insensitive
    
    This avoids failing visits for the wrong comparison check [1]
    
    [1] https://sentry.softwareheritage.org/share/issue/27017710a5ec49f991910a780d38d4ab/

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/146/ for more details.

Harbormaster completed remote builds in B19218: Diff 18110.Feb 15 2021, 5:01 PM

ardumont requested review of this revision.Feb 15 2021, 5:01 PM

vsellier accepted this revision.Feb 15 2021, 5:22 PM

This revision is now accepted and ready to land.Feb 15 2021, 5:22 PM

Closed by commit rDLDHG71cfd100180f: mercurial.loader: Make error comparison case-insensitive (authored by ardumont). · Explain WhyFeb 15 2021, 5:23 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDHG71cfd100180f: mercurial.loader: Make error comparison case-insensitive.