Differential D5049

loader: Mark visit status as failed when relevant
ClosedPublic
Actions

Authored by vsellier on Feb 9 2021, 3:57 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T3030: Improve loaders to deal with new visit status events

Commits

rDLDHG1f96493ef318: loader: Mark visit status as failed when relevant

Summary

Related to T3030

Test Plan

tox failing until swh.loader.core > 0.16 is released

Diff Detail

Repository

rDLDHG Mercurial loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vsellier created this revision.Feb 9 2021, 3:57 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 9 2021, 3:57 PM

Build has FAILED

Patch application report for D5049 (id=18000)

Rebasing onto 1965d6ec1e...

Current branch diff-target is up to date.

Changes applied before test

commit 1f96493ef318ed02a674efb4885c2d8d547154e0
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Tue Feb 9 12:28:51 2021 +0100

    loader: Mark visit status as failed when relevant
    
    Related to T3030

Link to build: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/139/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/139/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 9 2021, 3:57 PM

Harbormaster failed remote builds in B19121: Diff 18000!

Build is green

Patch application report for D5049 (id=18000)

Rebasing onto 1965d6ec1e...

Current branch diff-target is up to date.

Changes applied before test

commit 1f96493ef318ed02a674efb4885c2d8d547154e0
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Tue Feb 9 12:28:51 2021 +0100

    loader: Mark visit status as failed when relevant
    
    Related to T3030

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/141/ for more details.

Harbormaster completed remote builds in B19121: Diff 18000.Feb 11 2021, 11:55 AM

vsellier requested review of this revision.Feb 11 2021, 11:55 AM

vlorentz accepted this revision.Feb 11 2021, 3:51 PM

This revision is now accepted and ready to land.Feb 11 2021, 3:51 PM

Closed by commit rDLDHG1f96493ef318: loader: Mark visit status as failed when relevant (authored by vsellier). · Explain WhyFeb 11 2021, 6:21 PM

This revision was automatically updated to reflect the committed changes.

vsellier added a commit: rDLDHG1f96493ef318: loader: Mark visit status as failed when relevant.