Page MenuHomeSoftware Heritage
Differential D47

Refactor the search functionality
ClosedPublic
Actions

Authored by jbertran on Jun 13 2016, 5:31 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
R65:e8539fd5b1a3: browse: move more logic to api, update tests to reflect changes
R65:74cd22fc1e35: api tests: fix contract error
R65:2fa16c48af9e: service tests: fix yaml search test
R65:041ded85bbcb: browse: reflect displacing search logic to the api layer.
R65:2ee2fa449b7e: service: add search_hash returning boolean, fix docstring for lookup_hash
R65:53a361d9dc1a: api: add multiple hash POST request search treatment
R65:2e9f4f0451d2: search template: update to reflect api and browse changes
rDWAPPSe8539fd5b1a3: browse: move more logic to api, update tests to reflect changes
rDWAPPS2e9f4f0451d2: search template: update to reflect api and browse changes
rDWAPPS74cd22fc1e35: api tests: fix contract error
rDWAPPS2fa16c48af9e: service tests: fix yaml search test
rDWAPPS041ded85bbcb: browse: reflect displacing search logic to the api layer.
rDWAPPS53a361d9dc1a: api: add multiple hash POST request search treatment
rDWAPPS2ee2fa449b7e: service: add search_hash returning boolean, fix docstring for lookup_hash
Summary

Refactor api and browse to be more consistent

  • move search logic to the api layer
  • update template and browse to reflect this

Changes go towards T437

Diff Detail

Repository
rDWAPPS Web applications
Branch
SearchFixes
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 185
Build 278: Software Heritage Python tests
Build 277: arc lint + arc unit

Event Timeline

jbertran updated this revision to Diff 155.Jun 13 2016, 5:31 PM
jbertran retitled this revision from to Refactor the search functionality.
jbertran updated this object.
jbertran edited the test plan for this revision. (Show Details)
Herald added a reviewer: Reviewers. · View Herald TranscriptJun 13 2016, 5:31 PM
jbertran updated this revision to Diff 156.Jun 14 2016, 10:32 AM
jbertran edited edge metadata.
  • service tests: fix yaml search test
Herald edited edge metadata. · View Herald TranscriptJun 14 2016, 10:32 AM
jbertran updated this revision to Diff 157.Jun 14 2016, 11:47 AM
jbertran edited edge metadata.
  • browse: move more logic to api, update tests to reflect changes
Herald edited edge metadata. · View Herald TranscriptJun 14 2016, 11:47 AM
ardumont added a subscriber: ardumont.Jun 14 2016, 11:50 AM
ardumont added inline comments.
swh/web/ui/tests/views/test_api.py
334

you do not return the 'algo' in the search_hash ^^

jbertran updated this revision to Diff 158.Jun 14 2016, 11:52 AM
jbertran edited edge metadata.
  • api tests: fix contract error
Herald edited edge metadata. · View Herald TranscriptJun 14 2016, 11:52 AM
ardumont accepted this revision.Jun 14 2016, 11:53 AM
ardumont added a reviewer: ardumont.
This revision is now accepted and ready to land.Jun 14 2016, 11:53 AM
Closed by commit rDWAPPS2ee2fa449b7e: service: add search_hash returning boolean, fix docstring for lookup_hash (authored by jbertran). · Explain WhyJun 14 2016, 12:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
web/
ui/
18 lines
templates/
18 lines
tests/
39 lines
views/
42 lines
113 lines
views/
46 lines
55 lines

Diff 155

View Options

swh/web/ui/service.py

Loading...
View Options

swh/web/ui/templates/upload_and_search.html

Loading...
View Options

swh/web/ui/tests/test_service.py

Loading...
View Options

swh/web/ui/tests/views/test_api.py

Loading...
View Options

swh/web/ui/tests/views/test_browse.py

Loading...
View Options

swh/web/ui/views/api.py

Loading...
View Options

swh/web/ui/views/browse.py

Loading...
About · Developer information · Legal