Page MenuHomeSoftware Heritage

Allow to configure the index to use on elasticsearch
ClosedPublic

Authored by vsellier on Dec 23 2020, 1:03 PM.

Details

Summary

It will allow to perform some tests on different index configuration
on the same elasticsearch server

Related to T2904

Test Plan

tox

Diff Detail

Repository
rDSEA Archive search
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18095
Build 27937: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 27936: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D4785 (id=16945)

Rebasing onto be14169ca4...

Current branch diff-target is up to date.
Changes applied before test
commit a3474f6956b656b28306b90a00148f08aa954ce9
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Wed Dec 23 13:01:31 2020 +0100

    Allow to configure the index to use on elasticsearch
    
    It will allow to perform some tests on different index configuration
    on the same elasticsearch server
    
    Related to T2904

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/67/ for more details.

vlorentz added a subscriber: vlorentz.

This works for now because we only have an index for origins; but we're planning to have more in the future (eg. for revisions).

Instead of passing the whole name as configuration, could use use a prefix instead? Thanks!

This revision now requires changes to proceed.Dec 23 2020, 1:45 PM

Use a prefix instead of changing the index name.
Make it optional to avoid to have to rename the index on the instances already deployed

Build is green

Patch application report for D4785 (id=16955)

Rebasing onto be14169ca4...

Current branch diff-target is up to date.
Changes applied before test
commit 59ed9f24496e45f18cadf2ac585269fbca0a9d3a
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Wed Dec 23 13:01:31 2020 +0100

    Allow to prefix the index name(s)
    
    It will allow to perform some tests on different index configurations
    on the same elasticsearch server
    
    Related to T2904

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/68/ for more details.

you don't need to add swh_search_with_prefix and swh_search_without_prefix if they only get used once; you can call get_search directly in the tests instead

This revision now requires changes to proceed.Dec 23 2020, 3:14 PM

Remove useless fixture declaration

Build is green

Patch application report for D4785 (id=16957)

Rebasing onto be14169ca4...

Current branch diff-target is up to date.
Changes applied before test
commit 5560ba0ad621473e71f1834766303b94d887c252
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Wed Dec 23 13:01:31 2020 +0100

    Allow to prefix the index name(s)
    
    It will allow to perform some tests on different index configurations
    on the same elasticsearch server
    
    Related to T2904

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/69/ for more details.

This revision is now accepted and ready to land.Dec 23 2020, 3:50 PM
This revision was automatically updated to reflect the committed changes.