Differential D4740

cli: add --config-file option to 'swh web' group
ClosedPublic
Actions

Authored by haltode on Dec 15 2020, 11:48 AM.

Details

Reviewers

zack

Group Reviewers

Reviewers

Maniphest Tasks

T2872: Allow passing configuration file to swh web CLI

Commits

rDWCLIb2df1673fbf8: cli: add --config-file option to 'swh web' group

Summary

Closes T2872.

Diff Detail

Repository

rDWCLI Web client

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

haltode created this revision.Dec 15 2020, 11:48 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 15 2020, 11:48 AM

Build is green

Patch application report for D4740 (id=16787)

Rebasing onto 4b1e763279...

Current branch diff-target is up to date.

Changes applied before test

commit b2df1673fbf848bbe318f70a07c1921aa1c47751
Author: Thibault Allançon <haltode@gmail.com>
Date:   Tue Dec 15 11:04:31 2020 +0100

    cli: add --config-file option to 'swh web' group
    
    Closes T2872.

See https://jenkins.softwareheritage.org/job/DWCLI/job/tests-on-diff/36/ for more details.

Harbormaster completed remote builds in B17946: Diff 16787.Dec 15 2020, 11:49 AM

LGTM (but please fix the minor docstring point I've mentioned before landing)

swh/web/client/client.py
145–146	minor point here: instead of dropping the mention of the hard-coded default value here, you should point to the dictionary in the code that contains it (e.g., via a sphinx ref)

This revision is now accepted and ready to land.Dec 15 2020, 11:57 AM

haltode marked an inline comment as done.Dec 15 2020, 1:09 PM

haltode added inline comments.