cli: move 'swh auth' group to 'swh web auth'
ClosedPublic
Actions

Authored by haltode on Dec 14 2020, 1:28 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T2873: Move "swh auth" CLI command group to "swh web auth"

Commits

rDWCLI4b1e763279aa: cli: move 'swh auth' group to 'swh web auth'

Summary

Closes T2873.

Diff Detail

Repository

rDWCLI Web client

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

haltode created this revision.Dec 14 2020, 1:28 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 14 2020, 1:28 PM

Build is green

Patch application report for D4733 (id=16766)

Rebasing onto 176c6b134c...

Current branch diff-target is up to date.

Changes applied before test

commit 4b1e763279aa80bac4119799fe122279dfe1b3da
Author: Thibault Allançon <haltode@gmail.com>
Date:   Mon Dec 14 13:26:56 2020 +0100

    cli: move 'swh auth' group to 'swh web auth'
    
    Closes T2873.

See https://jenkins.softwareheritage.org/job/DWCLI/job/tests-on-diff/35/ for more details.

Harbormaster completed remote builds in B17925: Diff 16766.Dec 14 2020, 1:29 PM

haltode added a reviewer: anlambert.Dec 14 2020, 1:31 PM

LGTM but the diff is hard to read. Simply moving the @swh_cli_group.group(name="web", context_settings=CONTEXT_SETTINGS) block at the top of the file and adapting the sub commands would have been clearer.

Also tests are missing and could have been added in D4696 ...

This revision is now accepted and ready to land.Dec 14 2020, 1:50 PM

Closed by commit rDWCLI4b1e763279aa: cli: move 'swh auth' group to 'swh web auth' (authored by haltode). · Explain WhyDec 14 2020, 4:25 PM

This revision was automatically updated to reflect the committed changes.

haltode added a commit: rDWCLI4b1e763279aa: cli: move 'swh auth' group to 'swh web auth'.