search.journal_client: Fix key error
ClosedPublic
Actions

Authored by ardumont on Dec 9 2020, 10:26 PM.

Details

Reviewers

vsellier

Group Reviewers

Reviewers

Maniphest Tasks

T2817: Enable the swh-search environment in staging

Commits

rDSEAab27eae1356a: search.journal_client: Fix key error

Summary

Prior to this commit the key used was origin_url. After running the following
through docker, the actual key used is id.

As demonstrated by the stacktrace [1] and the extracted sample [2] (no origin_url but the id).

Also, as plainly defined in the swh.indexer.storage.model module [3]

Related to T2817

[1] P899
[2] P898
[3] https://forge.softwareheritage.org/source/swh-indexer/browse/master/swh/indexer/storage/model.py$135

Test Plan

tox

Diff Detail

Repository

rDSEA Archive search

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Dec 9 2020, 10:26 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 9 2020, 10:26 PM

Build is green

Patch application report for D4710 (id=16682)

Rebasing onto e72a785757...

Current branch diff-target is up to date.

Changes applied before test

commit ab27eae1356a3a36475c65421abe0f9dcc2a6192
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Dec 9 22:16:23 2020 +0100

    search.journal_client: Fix key error
    
    Prior to this commit the key used was origin_url. After running the following
    through docker, the actual key used is `id`.
    
    Related to T2817

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/54/ for more details.

Harbormaster completed remote builds in B17855: Diff 16682.Dec 9 2020, 10:28 PM

ardumont edited the summary of this revision. (Show Details)Dec 9 2020, 10:38 PM

ardumont edited the summary of this revision. (Show Details)Dec 10 2020, 9:34 AM