Page MenuHomeSoftware Heritage

fuse: add dedicated logger instead of root logger
ClosedPublic

Authored by haltode on Dec 3 2020, 10:11 AM.

Diff Detail

Repository
rDFUSE FUSE virtual file system
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D4652 (id=16504)

Rebasing onto 4a2f73c9ba...

Current branch diff-target is up to date.
Changes applied before test
commit 4ff6e1fd44d8d7090de2b555c88360d1438f1758
Author: Thibault Allançon <haltode@gmail.com>
Date:   Wed Dec 2 13:03:54 2020 +0100

    fuse: add dedicated logger instead of root logger

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/219/ for more details.

haltode retitled this revision from fuse: add dedicated logger instead of root logger to WIP fuse: add dedicated logger instead of root logger.Dec 3 2020, 10:15 AM
zack requested changes to this revision.Dec 3 2020, 4:41 PM
zack added a subscriber: zack.
zack added inline comments.
docs/configuration.rst
71

does this really need to be a deep pattern like swh.fuse.fuse? wouldn't swh.fuse work? if yes, we should prefer the latter for clarity

swh/fuse/fuse.py
106

better/shorter: "Found blob %s in cache"

(note: there was an inconsistency about using/not using function names in logging, which I'm also fixing here.)

115

It is preferable to log this when you start fetching from Web API, so that you can notice hangs in the logs.
The message should then be something like: "Retrieving blob %s via web API..."

129

"Found history of %s in cache (%d ancestors)"

142–144

anticipate this before retrieval, and log as "Retrieving history of %s via graph API..."

157

"Found %d visits for origin '%s' in cache"

184

anticipate and log as "Retrieving visits for origin '%s' via web API..."

185–188

"Cannot fetch visits for origin '%s': %s"

319

typo: "fs.looger"

This revision now requires changes to proceed.Dec 3 2020, 4:41 PM
haltode marked 9 inline comments as done.
  • Rebase on master
  • Fix zack comments

Build is green

Patch application report for D4652 (id=16527)

Rebasing onto fbfed4d9a4...

Current branch diff-target is up to date.
Changes applied before test
commit 555e11a334d45f78f14daeb197a78f182037fe0c
Author: Thibault Allançon <haltode@gmail.com>
Date:   Wed Dec 2 13:03:54 2020 +0100

    fuse: add dedicated logger instead of root logger

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/222/ for more details.

haltode retitled this revision from WIP fuse: add dedicated logger instead of root logger to fuse: add dedicated logger instead of root logger.Dec 3 2020, 5:41 PM
haltode edited the summary of this revision. (Show Details)

Build is green

Patch application report for D4652 (id=16529)

Rebasing onto fbfed4d9a4...

Current branch diff-target is up to date.
Changes applied before test
commit b8e01e75f9c1e54854ac4754c3678ecd123eb93e
Author: Thibault Allançon <haltode@gmail.com>
Date:   Wed Dec 2 13:03:54 2020 +0100

    fuse: add dedicated logger instead of root logger

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/223/ for more details.

Build is green

Patch application report for D4652 (id=16531)

Rebasing onto fbfed4d9a4...

Current branch diff-target is up to date.
Changes applied before test
commit 9a366536a07c14c52b46e6ba38f0abb772075f7c
Author: Thibault Allançon <haltode@gmail.com>
Date:   Wed Dec 2 13:03:54 2020 +0100

    fuse: add dedicated logger instead of root logger

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/224/ for more details.

This revision is now accepted and ready to land.Dec 3 2020, 6:28 PM

Build is green

Patch application report for D4652 (id=16534)

Rebasing onto 141277e4f5...

Current branch diff-target is up to date.
Changes applied before test
commit f3363d909f4bd7ea54f9b3d72f7c7fc4cfea1296
Author: Thibault Allançon <haltode@gmail.com>
Date:   Wed Dec 2 13:03:54 2020 +0100

    fuse: add dedicated logger instead of root logger

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/225/ for more details.