Details
Diff Detail
- Repository
- rDFUSE FUSE virtual file system
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Build is green
Patch application report for D4636 (id=16447)
Rebasing onto 91da323979...
Current branch diff-target is up to date.
Changes applied before test
commit 444788afa4ade2cd14034648e404e45a59622a38
Author: Thibault Allançon <haltode@gmail.com>
Date: Tue Dec 1 10:53:28 2020 +0100
docs: update design and corresponding docstring
commit 79393541e2291d5c361d4f79463252119992a957
Author: Thibault Allançon <haltode@gmail.com>
Date: Tue Dec 1 10:21:09 2020 +0100
cache: small code cleanup
- Explicit data types in tables
- Add comments
- String formatting
commit 1e4f9a8c9dd40a02d3f2b5031d63e549ef171613
Author: Thibault Allançon <haltode@gmail.com>
Date: Tue Dec 1 10:20:38 2020 +0100
fuse: get_history: add missing docstringSee https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/207/ for more details.
I'm accepting this, but please fix the various minor issues I've pointed out before landing.
| docs/design.md | ||
|---|---|---|
| 184 ↗ | (On Diff #16447) | minor: s/Artifact/Artifact id/ (Because that's the key for the cache, not the artifact itself. The text below is already fine in specifying that an artifact ID is, depending on the case.) |
| 189 ↗ | (On Diff #16447) | minor: missing comma at the end of the line, after "origins visits" also, it should be "origin visits" |
| swh/fuse/cache.py | ||
| 117 ↗ | (On Diff #16447) | minor: I really hate DB schema strings mixed with code. Can you put this string in a DB_SCHEMA class attribute and exec it from here? |
| 193 ↗ | (On Diff #16447) | as above, please move this to a DB_SCHEMA class attribute |
| 232 ↗ | (On Diff #16447) | ditto |
Build is green
Patch application report for D4636 (id=16449)
Rebasing onto 91da323979...
Current branch diff-target is up to date.
Changes applied before test
commit 92ccb00b84cca80749987ac15d1df3d885635452
Author: Thibault Allançon <haltode@gmail.com>
Date: Tue Dec 1 10:53:28 2020 +0100
docs: update design and corresponding docstring
commit 05c0235b2ec13b58e88f0a5957e0a1f641f4dbcb
Author: Thibault Allançon <haltode@gmail.com>
Date: Tue Dec 1 10:21:09 2020 +0100
cache: small code cleanup
- Explicit data types in tables
- Add comments
- String formatting
commit 1e4f9a8c9dd40a02d3f2b5031d63e549ef171613
Author: Thibault Allançon <haltode@gmail.com>
Date: Tue Dec 1 10:20:38 2020 +0100
fuse: get_history: add missing docstringSee https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/208/ for more details.