Differential D4617

meta.json: add 'json-indent' option (default to 2)
ClosedPublic
Actions

Authored by haltode on Nov 27 2020, 10:08 AM.

Details

Reviewers

zack

Group Reviewers

Reviewers

Commits

rDFUSE6ab2e7363377: meta.json: add 'json-indent' option (default to 2)

Diff Detail

Repository

rDFUSE FUSE virtual file system

Branch

feature/pretty-print-meta-json

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 17558
Build 27141: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 27140: arc lint + arc unit

Event Timeline

haltode created this revision.Nov 27 2020, 10:08 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 27 2020, 10:08 AM

Build is green

Patch application report for D4617 (id=16366)

Rebasing onto c73312c854...

Current branch diff-target is up to date.

Changes applied before test

commit ad3d6da7b76c00e7f3791b0e66e3b26a916e60e8
Author: Thibault Allançon <haltode@gmail.com>
Date:   Fri Nov 27 10:06:20 2020 +0100

    meta.json: add 'json-indent' option (default to 4)

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/193/ for more details.

Harbormaster completed remote builds in B17558: Diff 16366.Nov 27 2020, 10:11 AM

LGTM

(but please change the default indent level as suggested before landing)

swh/fuse/cli.py
40	please make the default indent level 2, for consistency with jq (and being nicer to the eye)

This revision is now accepted and ready to land.Nov 27 2020, 10:14 AM

Use 2 indent instead of 4

This revision now requires review to proceed.Nov 27 2020, 10:14 AM

haltode marked an inline comment as done.Nov 27 2020, 10:15 AM

Build is green

Patch application report for D4617 (id=16367)

Rebasing onto c73312c854...

Current branch diff-target is up to date.

Changes applied before test

commit 6ab2e7363377fab56e7b30f8672410fbcee63f9c
Author: Thibault Allançon <haltode@gmail.com>
Date:   Fri Nov 27 10:06:20 2020 +0100

    meta.json: add 'json-indent' option (default to 2)

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/194/ for more details.

Harbormaster completed remote builds in B17559: Diff 16367.Nov 27 2020, 10:17 AM

haltode retitled this revision from meta.json: add 'json-indent' option (default to 4) to meta.json: add 'json-indent' option (default to 2).Nov 27 2020, 10:19 AM

zack accepted this revision.Nov 27 2020, 10:21 AM

This revision is now accepted and ready to land.Nov 27 2020, 10:21 AM

Closed by commit rDFUSE6ab2e7363377: meta.json: add 'json-indent' option (default to 2) (authored by haltode). · Explain WhyNov 27 2020, 10:23 AM

This revision was automatically updated to reflect the committed changes.

haltode added a commit: rDFUSE6ab2e7363377: meta.json: add 'json-indent' option (default to 2).

zack mentioned this in T2811: FUSE: fix various paper cuts (user testing 2020-11-24).Nov 27 2020, 12:20 PM