Page MenuHomeSoftware Heritage

meta.json: add 'json-indent' option (default to 2)
ClosedPublic

Authored by haltode on Nov 27 2020, 10:08 AM.

Diff Detail

Repository
rDFUSE FUSE virtual file system
Branch
feature/pretty-print-meta-json
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17558
Build 27141: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 27140: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D4617 (id=16366)

Rebasing onto c73312c854...

Current branch diff-target is up to date.
Changes applied before test
commit ad3d6da7b76c00e7f3791b0e66e3b26a916e60e8
Author: Thibault Allançon <haltode@gmail.com>
Date:   Fri Nov 27 10:06:20 2020 +0100

    meta.json: add 'json-indent' option (default to 4)

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/193/ for more details.

zack added a subscriber: zack.

LGTM

(but please change the default indent level as suggested before landing)

swh/fuse/cli.py
40

please make the default indent level 2, for consistency with jq (and being nicer to the eye)

This revision is now accepted and ready to land.Nov 27 2020, 10:14 AM
haltode removed a reviewer: zack.

Use 2 indent instead of 4

This revision now requires review to proceed.Nov 27 2020, 10:14 AM

Build is green

Patch application report for D4617 (id=16367)

Rebasing onto c73312c854...

Current branch diff-target is up to date.
Changes applied before test
commit 6ab2e7363377fab56e7b30f8672410fbcee63f9c
Author: Thibault Allançon <haltode@gmail.com>
Date:   Fri Nov 27 10:06:20 2020 +0100

    meta.json: add 'json-indent' option (default to 2)

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/194/ for more details.

haltode retitled this revision from meta.json: add 'json-indent' option (default to 4) to meta.json: add 'json-indent' option (default to 2).Nov 27 2020, 10:19 AM
This revision is now accepted and ready to land.Nov 27 2020, 10:21 AM