Differential D4592

cli.task_type: All task_type clis without a scheduler should raise
ClosedPublic
Actions

Authored by ardumont on Nov 25 2020, 3:40 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Commits

rDSCH1f68031c5fae: cli.task_type: All task_type clis without a scheduler should raise

Summary

As the code will plainly fail on calling methods on None instance if not caught
early.

Caught on a node on staging (I don't have the details anymore)

Test Plan

tox happy

Diff Detail

Repository

rDSCH Scheduling utilities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Nov 25 2020, 3:40 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 25 2020, 3:40 PM

Build is green

Patch application report for D4592 (id=16305)

Rebasing onto 9e5b17faa8...

Current branch diff-target is up to date.

Changes applied before test

commit c50763348cb09636c70d22a12393157f4ee7f8d6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Nov 25 15:30:10 2020 +0100

    cli.task_type: All task_type clis without a scheduler should raise
    
    As the code will plainly fail on calling methods on None instance if not caught
    early.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/78/ for more details.

Harbormaster completed remote builds in B17496: Diff 16305.Nov 25 2020, 3:42 PM

Add test on changes

Build is green

Patch application report for D4592 (id=16309)

Rebasing onto 9e5b17faa8...

Current branch diff-target is up to date.

Changes applied before test

commit 1f68031c5fae7140bdbc4473b63a305992dfcc83
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Nov 25 15:30:10 2020 +0100

    cli.task_type: All task_type clis without a scheduler should raise
    
    As the code will plainly fail on calling methods on None instance if not caught
    early.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/80/ for more details.

Harbormaster completed remote builds in B17500: Diff 16309.Nov 25 2020, 3:58 PM

ardumont edited the summary of this revision. (Show Details)Nov 25 2020, 3:59 PM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 26 2020, 4:57 PM

Closed by commit rDSCH1f68031c5fae: cli.task_type: All task_type clis without a scheduler should raise (authored by ardumont). · Explain Why

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSCH1f68031c5fae: cli.task_type: All task_type clis without a scheduler should raise.