Differential D4492

logging: replace f-strings in logging calls
ClosedPublic
Actions

Authored by haltode on Nov 17 2020, 2:43 PM.

Details

Reviewers

zack

Group Reviewers

Reviewers

Commits

rDFUSE2be0aa2f2b8c: logging: replace f-strings in logging calls

Summary

Do not unnecessarily format string (eg: when log statement is below
current log level).

Diff Detail

Repository

rDFUSE FUSE virtual file system

Branch

feature/logging-no-fstring

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 17136
Build 26448: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 26447: arc lint + arc unit

Event Timeline

haltode created this revision.Nov 17 2020, 2:43 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 17 2020, 2:43 PM

Build is green

Patch application report for D4492 (id=15933)

Rebasing onto 5fdda3d1cf...

Current branch diff-target is up to date.

Changes applied before test

commit 2be0aa2f2b8c46c7e511a8d95a07c3e4550da7a7
Author: Thibault Allançon <haltode@gmail.com>
Date:   Tue Nov 17 14:39:21 2020 +0100

    logging: replace f-strings in logging calls
    
    Do not unnecessarily format string (eg: when log statement is below
    current log level).

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/157/ for more details.

Harbormaster completed remote builds in B17136: Diff 15933.Nov 17 2020, 2:44 PM

zack accepted this revision.Nov 17 2020, 2:46 PM

This revision is now accepted and ready to land.Nov 17 2020, 2:46 PM

Closed by commit rDFUSE2be0aa2f2b8c: logging: replace f-strings in logging calls (authored by haltode). · Explain WhyNov 17 2020, 2:54 PM

This revision was automatically updated to reflect the committed changes.

haltode added a commit: rDFUSE2be0aa2f2b8c: logging: replace f-strings in logging calls.