Page MenuHomeSoftware Heritage

fs: history: add by-date/ sharded directory
ClosedPublic

Authored by haltode on Tue, Nov 17, 11:28 AM.

Diff Detail

Repository
rDFUSE FUSE virtual file system
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

haltode created this revision.Tue, Nov 17, 11:28 AM

Build is green

Patch application report for D4489 (id=15926)

Rebasing onto 5fdda3d1cf...

Current branch diff-target is up to date.
Changes applied before test
commit 48fa448ffdb9980c3313d10c4a2ab2660418d4cd
Author: Thibault Allançon <haltode@gmail.com>
Date:   Tue Nov 17 10:46:58 2020 +0100

    fs: history: add by-date/ sharded directory
    
    Closes T2773.

commit 7a3ba79124a135ece42984168ebcd8cf439ba340
Author: Thibault Allançon <haltode@gmail.com>
Date:   Tue Nov 17 10:46:49 2020 +0100

    cache: fix exception when storing empty history (for root commit)

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/155/ for more details.

haltode updated this revision to Diff 15927.Tue, Nov 17, 11:32 AM

Add comment

Build is green

Patch application report for D4489 (id=15927)

Rebasing onto 5fdda3d1cf...

Current branch diff-target is up to date.
Changes applied before test
commit d83cf2a30be560d1e3bc1dff6f8356f7ea7da242
Author: Thibault Allançon <haltode@gmail.com>
Date:   Tue Nov 17 10:46:58 2020 +0100

    fs: history: add by-date/ sharded directory
    
    Closes T2773.

commit 7a3ba79124a135ece42984168ebcd8cf439ba340
Author: Thibault Allançon <haltode@gmail.com>
Date:   Tue Nov 17 10:46:49 2020 +0100

    cache: fix exception when storing empty history (for root commit)

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/156/ for more details.

haltode added inline comments.Tue, Nov 17, 12:53 PM
swh/fuse/fs/artifact.py
213–224 ↗(On Diff #15927)

Hm, i realize now that starting the new thread here might mean multiple concurrent access to the direntry cache since we are modifying it as well a few lines down the code. So move this after by_hash and by_page? Also, put all the direntry cache filling in the separate cache?

haltode updated this revision to Diff 15936.Tue, Nov 17, 2:57 PM
  • Rebase on master
  • Use asyncio.create_task() instead of asyncio.run_coroutine_threadsafe

Build is green

Patch application report for D4489 (id=15936)

Rebasing onto 2be0aa2f2b...

Current branch diff-target is up to date.
Changes applied before test
commit 93d047340081b3f3602c701f3903cf27c8e42906
Author: Thibault Allançon <haltode@gmail.com>
Date:   Tue Nov 17 10:46:58 2020 +0100

    fs: history: add by-date/ sharded directory
    
    Closes T2773.

commit 7372b73ecc5ebeca39956203ada7831c4b5331b6
Author: Thibault Allançon <haltode@gmail.com>
Date:   Tue Nov 17 10:46:49 2020 +0100

    cache: fix exception when storing empty history (for root commit)

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/158/ for more details.

haltode updated this revision to Diff 15958.Wed, Nov 18, 10:18 AM

New implem using the metadata on-disk cache.

Build is green

Patch application report for D4489 (id=15958)

Rebasing onto 2b1c921089...

First, rewinding head to replay your work on top of it...
Applying: cache: fix exception when storing empty history (for root commit)
Applying: fs: history: add by-date/ sharded directory
Applying: WIP: new implem
Changes applied before test
commit af7b55c158a4657c529e587001d11a20fcb25ff1
Author: Thibault Allançon <haltode@gmail.com>
Date:   Wed Nov 18 10:17:07 2020 +0100

    WIP: new implem

commit 78ceb74596f24a81435cae77f347493b8184a0e8
Author: Thibault Allançon <haltode@gmail.com>
Date:   Tue Nov 17 10:46:58 2020 +0100

    fs: history: add by-date/ sharded directory
    
    Closes T2773.

commit 0c26a00611ab1c9d455cb15bb3f04ad44cb5e05b
Author: Thibault Allançon <haltode@gmail.com>
Date:   Tue Nov 17 10:46:49 2020 +0100

    cache: fix exception when storing empty history (for root commit)

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/159/ for more details.

seirl accepted this revision.Wed, Nov 18, 12:49 PM
This revision is now accepted and ready to land.Wed, Nov 18, 12:49 PM
haltode updated this revision to Diff 15974.Wed, Nov 18, 1:18 PM

Squash commit

haltode retitled this revision from WIP: fs: history: add by-date/ sharded directory to fs: history: add by-date/ sharded directory.Wed, Nov 18, 1:19 PM
haltode edited the summary of this revision. (Show Details)

Build is green

Patch application report for D4489 (id=15974)

Rebasing onto 2b1c921089...

First, rewinding head to replay your work on top of it...
Applying: cache: fix exception when storing empty history (for root commit)
Applying: fs: history: add by-date/ sharded directory
Changes applied before test
commit 8ef9eca7914854345a74ff6ceda2d6cf3e88ca03
Author: Thibault Allançon <haltode@gmail.com>
Date:   Tue Nov 17 10:46:58 2020 +0100

    fs: history: add by-date/ sharded directory
    
    Closes T2773.

commit d18e5e17661ef324f0935274a56a850990797561
Author: Thibault Allançon <haltode@gmail.com>
Date:   Tue Nov 17 10:46:49 2020 +0100

    cache: fix exception when storing empty history (for root commit)

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/160/ for more details.

haltode updated this revision to Diff 15976.Wed, Nov 18, 1:23 PM

Rebase on master

Build is green

Patch application report for D4489 (id=15976)

Rebasing onto 2b1c921089...

Current branch diff-target is up to date.
Changes applied before test
commit 430fa0e24981bad59432f9ad5b1d9e8229176df8
Author: Thibault Allançon <haltode@gmail.com>
Date:   Tue Nov 17 10:46:58 2020 +0100

    fs: history: add by-date/ sharded directory
    
    Closes T2773.

commit 33909eb22572d84135d31fab6eda6745409c19cd
Author: Thibault Allançon <haltode@gmail.com>
Date:   Tue Nov 17 10:46:49 2020 +0100

    cache: fix exception when storing empty history (for root commit)

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/161/ for more details.