Page MenuHomeSoftware Heritage

Drop vcversioner from requirements
AbandonedPublic

Authored by olasd on Mon, Nov 16, 3:06 PM.

Details

Reviewers
None
Group Reviewers
Reviewers
Summary

vcversioner was already removed months ago.

Drop all deprecated uses of args in component factories

swh.storage and swh.objstorage, as well as swh.indexer itself, have deprecated
using an explicit args in their factories for a while; we can drop them now.

Test Plan

tox shows no more deprecation warnings

Diff Detail

Repository
rDCIDX Metadata indexer
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17105
Build 26401: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 26400: arc lint + arc unit

Event Timeline

olasd created this revision.Mon, Nov 16, 3:06 PM

Build is green

Patch application report for D4480 (id=15898)

Rebasing onto 340c73a196...

Current branch diff-target is up to date.
Changes applied before test
commit 440961d06c444a1412fefeea5cfdefe198184177
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Fri Oct 9 13:42:19 2020 +0200

    Drop all deprecated uses of `args` in component factories
    
    swh.storage and swh.objstorage, as well as swh.indexer itself, have deprecated
    using an explicit `args` in their factories for a while; we can drop them now.

commit 5de2b6e40c387350fb4409f2c1e2229565dda62f
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Fri Sep 25 17:25:56 2020 +0200

    Drop vcversioner from requirements
    
    vcversioner was already removed months ago.

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/119/ for more details.

olasd abandoned this revision.Mon, Nov 16, 3:11 PM

Messed up my arc diff --create.