Differential D4387

lister.debian.tests: Fix test
ClosedPublic
Actions

Authored by ardumont on Oct 30 2020, 9:09 AM.

Details

Reviewers

None

Group Reviewers

Reviewers

Commits

rDLSe2a861c801e5: debian.tests: Fix test

Summary

The scheduler fixture introduced truncates tables in between tests. The debian
tests unfortunately share state and it broke when that changed. This fixes the
test by avoiding the truncation of the scheduler db table "task".

Ideally those tests need to be reworked to avoid sharing state between tests.

[1] https://jenkins.softwareheritage.org/job/DLS/job/tests/1043

Diff Detail

Repository

rDLS Listers

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Oct 30 2020, 9:09 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 30 2020, 9:09 AM

ardumont retitled this revision from debian.tests: Fix test to lister.debian.tests: Fix test.Oct 30 2020, 9:12 AM

Build is green

Patch application report for D4387 (id=15513)

Rebasing onto a19cb5fb51...

Current branch diff-target is up to date.

Changes applied before test

commit e2a861c801e575935276bb1ac7ba5e549f9224cb
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 22:09:32 2020 +0100

    debian.tests: Fix test
    
    The scheduler fixture introduced truncates tables in between tests. The debian
    tests unfortunately share state and it broke when that changed. This fixes the
    test by avoiding the truncation of the scheduler db table "task".
    
    Ideally those tests need to be reworked to avoid sharing state between tests.
    
    [1] https://jenkins.softwareheritage.org/job/DLS/job/tests/1043

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/60/ for more details.

Harbormaster completed remote builds in B16738: Diff 15513.Oct 30 2020, 9:13 AM

ardumont added a child revision: D4388: tests: Reduce db initialization fixtures to a minimum.Oct 30 2020, 9:27 AM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 30 2020, 9:33 AM

Closed by commit rDLSe2a861c801e5: debian.tests: Fix test (authored by ardumont). · Explain Why

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLSe2a861c801e5: debian.tests: Fix test.