Differential D4383

indexer.cli: Fix missing retries_left parameter
ClosedPublic
Actions

Authored by ardumont on Oct 29 2020, 3:29 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Commits

rDCIDXa019603fe700: indexer.cli: Fix missing retries_left parameter

Summary

According to the task schema, that parameter should not be null and defaults to
0. But current scheduler backend implementation expects a value nonetheless and
if it's null, that breaks the call.

Not necessarily for review, just to ensure it's fine jenkins wise.

This should fix [1]

[1]
https://jenkins.softwareheritage.org/job/DENV/job/tests/lastFailedBuild/artifact/swh-indexer.log

Test Plan

tox

Diff Detail

Repository

rDCIDX Metadata indexer

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Oct 29 2020, 3:29 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 29 2020, 3:29 PM

Build is green

Patch application report for D4383 (id=15497)

Rebasing onto d910ad3ef2...

Current branch diff-target is up to date.

Changes applied before test

commit a019603fe700a5d3478846b927bc819318a43c6c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Oct 26 12:26:02 2020 +0100

    indexer.cli: Fix missing retries_left parameter
    
    According to the task schema, that parameter should not be null and defaults to
    0. But current scheduler backend implementation expects a value nonetheless and
    if it's null, that breaks the call.
    
    This should fix [1]
    
    [1]
    https://jenkins.softwareheritage.org/job/DENV/job/tests/lastFailedBuild/artifact/swh-indexer.log

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/99/ for more details.

Harbormaster completed remote builds in B16723: Diff 15497.Oct 29 2020, 3:31 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 29 2020, 3:31 PM

Closed by commit rDCIDXa019603fe700: indexer.cli: Fix missing retries_left parameter (authored by ardumont). · Explain Why

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDCIDXa019603fe700: indexer.cli: Fix missing retries_left parameter.