This also adds more tests around the instantiation.
Details
Details
- Reviewers
- None
- Group Reviewers
Reviewers - Commits
- rDCORE85117cbdbc4b: api.RPCServerApp: Adapt sync rpc server with async rpc server
tox
Diff Detail
Diff Detail
- Repository
- rDCORE Foundations and core functionalities
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 16544 Build 25494: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 25493: arc lint + arc unit
Event Timeline
| swh/core/api/tests/test_rpc_server.py | ||
|---|---|---|
| 30 | i swapped the test_endpoint into endpoint_test so that pytest does not try to try and fail to inject an inexistent fixture named test_data... | |
Comment Actions
Build is green
Patch application report for D4327 (id=15316)
Rebasing onto 97c091e04d...
Current branch diff-target is up to date.
Changes applied before test
commit 28913d5e8104ecc26141370494d4d7cc568404ee
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Thu Oct 22 13:22:39 2020 +0200
api.RPCServerApp: Adapt synchroneous implemention with the async oneSee https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/108/ for more details.
Comment Actions
Build is green
Patch application report for D4327 (id=15319)
Could not rebase; Attempt merge onto 97c091e04d...
Updating 97c091e..6e3c797 Fast-forward conftest.py | 5 ++++ swh/core/api/__init__.py | 7 ++++-- swh/core/api/tests/conftest.py | 3 --- swh/core/api/tests/test_rpc_server.py | 47 ++++++++++++++++++++++++----------- 4 files changed, 43 insertions(+), 19 deletions(-)
Changes applied before test
commit 6e3c797c6ce247f3e4ef6ccda542ea7c61268557
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Thu Oct 22 13:22:39 2020 +0200
api.RPCServerApp: Adapt synchroneous implemention with the async one
commit db31d8a0a665e039e9474ba0bec7a73c5fe3a4cd
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Thu Oct 22 13:44:12 2020 +0200
Move pytest_plugin declaration to top-level conftest
Defining 'pytest_plugins' in a non-top-level conftest is no longer supported
because it affects the entire directory tree in a non-explicit way.See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/111/ for more details.
Comment Actions
Build is green
Patch application report for D4327 (id=15322)
Rebasing onto db31d8a0a6...
Current branch diff-target is up to date.
Changes applied before test
commit 85117cbdbc4bc7f91d801e04fb33aadb6af97806
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Thu Oct 22 13:22:39 2020 +0200
api.RPCServerApp: Adapt sync rpc server with async rpc server
This also adds more tests around the instantiation of such servers.See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/112/ for more details.