Page MenuHomeSoftware Heritage

indexer.storage: Add tests on signature type for all indexer storage implems
AbandonedPublic

Authored by ardumont on Thu, Oct 15, 3:47 PM.

Details

Reviewers
None
Group Reviewers
Reviewers
Summary

Depends on D4272

Test Plan

tox
(failing on type divergence which i don't get for now)

Diff Detail

Repository
rDCIDX Metadata indexer
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16336
Build 25153: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 25152: arc lint + arc unit

Unit TestsFailed

TimeTest
3 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.indexer.tests.storage.test_init::test_init_types[local-IndexerStorage-kwargs1]
class_name = 'local' expected_class = <class 'swh.indexer.storage.IndexerStorage'> kwargs = {'db': 'something'}
39 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.indexer.tests.storage.test_storage::test_types
swh_indexer_storage = <swh.indexer.storage.IndexerStorage object at 0x7f04e09a8ef0> def test_types(swh_indexer_storage) -> None:
351 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.indexer.tests.test_cli::test_origin_metadata_reindex_divisor
@pytest.fixture def idx_storage(): """An instance of in-memory indexer storage that gets injected into all
254 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.indexer.tests.test_cli::test_origin_metadata_reindex_dry_run
@pytest.fixture def idx_storage(): """An instance of in-memory indexer storage that gets injected into all
453 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.indexer.tests.test_cli::test_origin_metadata_reindex_empty_db
@pytest.fixture def idx_storage(): """An instance of in-memory indexer storage that gets injected into all
View Full Test Results (19 Failed · 325 Passed · 15 Skipped)

Event Timeline

ardumont created this revision.Thu, Oct 15, 3:47 PM

Build has FAILED

Patch application report for D4273 (id=15110)

Could not rebase; Attempt merge onto c6afd9d798...

Updating c6afd9d..f7a3404
Fast-forward
 requirements.txt                       |  1 +
 swh/indexer/storage/__init__.py        | 60 +++++++++++++++-------
 swh/indexer/storage/interface.py       |  5 +-
 swh/indexer/tests/storage/test_init.py | 92 ++++++++++++++++++++++++++++++++++
 4 files changed, 140 insertions(+), 18 deletions(-)
 create mode 100644 swh/indexer/tests/storage/test_init.py
Changes applied before test
commit f7a3404dbd9d74c6741b7647e74825697977968e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 15 15:47:57 2020 +0200

    indexer.storage: Add tests on type for all storage implementations

commit 255c1961d615049ee2b19e819793a7b9a20d3230
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 15 15:42:58 2020 +0200

    swh.indexer.storage: Unify get_indexer_storage function with others
    
    Related to T1410

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/89/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/89/console

ardumont abandoned this revision.Thu, Oct 15, 3:52 PM

I think it's unneeded, there is one already.