Paths

Table of Contentst

Differential D4160

client: make API response typify-ing optional
ClosedPublic
Actions

Authored by haltode on Oct 6 2020, 3:49 PM.

Details

Reviewers

zack

Group Reviewers

Reviewers

Maniphest Tasks

T2646: Typifying the returned JSON should be optional

Commits

rDWCLI5d04bc970f17: client: make API response typify-ing optional

Summary

Closes T2646.

Diff Detail

Repository

rDWCLI Web client

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

haltode created this revision.Oct 6 2020, 3:49 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 6 2020, 3:49 PM

Build is green

Patch application report for D4160 (id=14663)

Rebasing onto 677e98565d...

Current branch diff-target is up to date.

Changes applied before test

commit d9e55d0e75af0bf9bd90a98986a2eb6669e58078
Author: Thibault Allançon <haltode@gmail.com>
Date:   Tue Oct 6 14:28:03 2020 +0200

    client: make API response typify-ing optional
    
    Closes T2646.

See https://jenkins.softwareheritage.org/job/DWCLI/job/tests-on-diff/21/ for more details.

Harbormaster completed remote builds in B15940: Diff 14663.Oct 6 2020, 3:50 PM

zack requested changes to this revision.Oct 6 2020, 4:24 PM

zack added a subscriber: zack.

zack added inline comments.

swh/web/client/client.py
248	`"if True, convert return value to pythonic types wherever possible, otherwise return raw JSON types (default: True)"` same in all other occurrences of this arg description string
swh/web/client/tests/test_web_api_client.py
151	`test_get_json`, maybe ?

This revision now requires changes to proceed.Oct 6 2020, 4:24 PM

update documentation string
rename new test to test_get_json

haltode marked 2 inline comments as done.Oct 6 2020, 4:31 PM

Build is green

Patch application report for D4160 (id=14665)

Rebasing onto 677e98565d...

Current branch diff-target is up to date.

Changes applied before test

commit bb23b299617e5c3d337032b21da3151ecb744a33
Author: Thibault Allançon <haltode@gmail.com>
Date:   Tue Oct 6 14:28:03 2020 +0200

    client: make API response typify-ing optional
    
    Closes T2646.

See https://jenkins.softwareheritage.org/job/DWCLI/job/tests-on-diff/22/ for more details.

Harbormaster completed remote builds in B15942: Diff 14665.Oct 6 2020, 4:32 PM

zack requested changes to this revision.Oct 6 2020, 4:36 PM

zack added inline comments.

swh/web/client/client.py
248–249	second line should be indented to be correct Sphinx/Napoleon markup, see: https://wiki.softwareheritage.org/wiki/Sphinx_gotchas#Args

This revision now requires changes to proceed.Oct 6 2020, 4:36 PM

Fix indentation in documentation string

haltode marked an inline comment as done.Oct 6 2020, 4:41 PM

Build is green

Patch application report for D4160 (id=14666)

Rebasing onto 677e98565d...

Current branch diff-target is up to date.

Changes applied before test

commit 5d04bc970f17dab54e97916b55cd850c3603f6bd
Author: Thibault Allançon <haltode@gmail.com>
Date:   Tue Oct 6 14:28:03 2020 +0200

    client: make API response typify-ing optional
    
    Closes T2646.

See https://jenkins.softwareheritage.org/job/DWCLI/job/tests-on-diff/23/ for more details.

Harbormaster completed remote builds in B15943: Diff 14666.Oct 6 2020, 4:41 PM

zack accepted this revision.Oct 6 2020, 4:45 PM

This revision is now accepted and ready to land.Oct 6 2020, 4:45 PM

Closed by commit rDWCLI5d04bc970f17: client: make API response typify-ing optional (authored by haltode). · Explain WhyOct 6 2020, 4:55 PM

This revision was automatically updated to reflect the committed changes.

haltode added a commit: rDWCLI5d04bc970f17: client: make API response typify-ing optional.