Differential D4113

Vagrantfile: Declare variables once then reuse to be more dry
ClosedPublic
Actions

Authored by ardumont on Oct 1 2020, 2:31 PM.

Details

Reviewers

vsellier

Group Reviewers

Reviewers

Commits

rSENV7c4fcc104e4c: Vagrantfile: Declare variables once then reuse to be more dry

Summary

I plan to add a new node for the deposit and i'd like to avoid having
to repeat again that setup.

It's probably possible to be even more terse but my ruby is kinda dusty ;)

Test Plan

vagrant up test (from a fresh start and it still works)

Diff Detail

Repository

rSENV Puppet Environment

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 15761
Build 24263: arc lint + arc unit

Event Timeline

ardumont created this revision.Oct 1 2020, 2:31 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 1 2020, 2:31 PM

Harbormaster completed remote builds in B15761: Diff 14489.Oct 1 2020, 2:31 PM

nice improvement, thanks

This revision is now accepted and ready to land.Oct 1 2020, 3:48 PM

Rebase (git config was off)

Harbormaster completed remote builds in B15774: Diff 14505.Oct 1 2020, 3:55 PM

Closed by commit rSENV7c4fcc104e4c: Vagrantfile: Declare variables once then reuse to be more dry (authored by ardumont). · Explain WhyOct 1 2020, 3:59 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rSENV7c4fcc104e4c: Vagrantfile: Declare variables once then reuse to be more dry.

Revision Contents
Changeset List

Path

Size

Vagrantfile

92 lines

Diff 14489

View Options

Vagrantfile: Declare variables once then reuse to be more dryClosedPublicActions