Differential D406

PyPi Lister
ClosedPublic
Actions

Authored by ardumont on Sep 6 2018, 1:30 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Summary

Related T422

Diff Detail

Repository

Branch

lister-pypi

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 1378
Build 1722: arc lint + arc unit

Event Timeline

ardumont created this revision.Sep 6 2018, 1:30 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 6 2018, 1:30 PM

Harbormaster completed remote builds in B1377: Diff 1265.Sep 6 2018, 1:30 PM

Looks good to me. I have added a few inline comments for some typos.

README.md
165	s/debian/pypi/
swh/lister/core/lister_transports.py
213	s/request/requests/
swh/lister/pypi/lister.py
16	is this comment still relevant here ?
46	what the point of shuffling the package names here ?

Thanks! Nice catches!

swh/lister/pypi/lister.py
16	No ;)
46	It's not really a point. It's for consistency reason. In the other listers (inheriting from IndexingRefreshListerTask), they compute the range of pages to list and shuffle those around.

doc: Fix typos according to review

Harbormaster completed remote builds in B1378: Diff 1266.Sep 6 2018, 2:58 PM

anlambert accepted this revision.Sep 6 2018, 2:59 PM

This revision is now accepted and ready to land.Sep 6 2018, 2:59 PM

Merged in master

Revision Contents
Changeset List

Path

Size

48 lines

swh/

lister/

7 lines

core/

lister_transports.py

81 lines

simple_lister.py

76 lines

pypi/

76 lines

16 lines

20 lines

Diff 1266

README.md

Loading...

swh/lister/cli.py

Loading...

swh/lister/core/lister_transports.py

Loading...

swh/lister/core/simple_lister.py

Loading...

swh/lister/pypi/init.py

Loading...

swh/lister/pypi/lister.py

Loading...

swh/lister/pypi/models.py

Loading...

swh/lister/pypi/tasks.py

Loading...