Page MenuHomeSoftware Heritage

WIP: add permissions on edge labels
AbandonedPublic

Authored by haltode on Wed, Sep 16, 11:28 AM.

Details

Reviewers
seirl
Summary

Refactor existing labels (filename) into a new SwhLabel class to regroup both
filenames and permissions.

Test Plan

Not tested yet.

Diff Detail

Repository
rDGRPH Graph service
Branch
add-edge-label-permissions
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15154
Build 23363: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 23362: arc lint + arc unit

Event Timeline

haltode created this revision.Wed, Sep 16, 11:28 AM

Build is green

Patch application report for D3962 (id=13943)

Rebasing onto eaf0323a1c...

Current branch diff-target is up to date.
Changes applied before test
commit 6ff8bdb2776886e5dfe52dc82ecf30527adff42e
Author: Thibault Allançon <haltode@gmail.com>
Date:   Wed Sep 16 10:42:32 2020 +0200

    WIP: add permissions on edge labels

See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/31/ for more details.

haltode abandoned this revision.Mon, Sep 21, 2:37 PM

Abandoning this diff because:

  • swh-graph codebase got updated recently to remove all occurrences of SWH PID in favor of the SWHID terminology.
  • Implementation needs to be redone entirely (create a new FixedWidthLongListLabel in webgraph and store both the filename and permissions metadata into one long object).