Differential D3731

vault.to_disk: Rename content_get call to content_get_data
AbandonedPublic
Actions

Authored by ardumont on Aug 6 2020, 11:29 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Test Plan

tox
(failing until storage release > 0.12)

Diff Detail

Repository

rDVAU Software Heritage Vault

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 14401
Build 22137: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 22136: arc lint + arc unit

Event Timeline

ardumont created this revision.Aug 6 2020, 11:29 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 6 2020, 11:29 PM

ardumont abandoned this revision.Aug 6 2020, 11:30 PM

Build has FAILED

Patch application report for D3731 (id=13135)

Could not rebase; Attempt merge onto 1c0ae80d8e...

Updating 1c0ae80..cc9e176
Fast-forward
 swh/vault/to_disk.py | 31 ++++++++++++++++++++-----------
 1 file changed, 20 insertions(+), 11 deletions(-)

Changes applied before test

commit cc9e17637ade92a2a2f1dbbb2dde7564985a0771
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Aug 6 23:30:00 2020 +0200

    vault.to_disk: Rename content_get call to content_get_data

commit 2618d5b728a91617ff50b017c10fc86df857854f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Aug 6 23:28:46 2020 +0200

    vault.to_disk: Simplify and type existing code

Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/10/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/10/console

Harbormaster failed remote builds in B14401: Diff 13135!Aug 6 2020, 11:30 PM