Differential D3720

Transform inline sample-folder into archive and adapt fixture accordingly
ClosedPublic
Actions

Authored by ardumont on Aug 6 2020, 12:05 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Maniphest Tasks

T2105: Migrate from vcversioner to setuptools-scm

Commits

rDTSCN432c50daf2fc: Transform inline sample-folder into archive and adapt fixture accordingly

Summary

Since the setuptools-scm migration, the build fails because the sample-folder
within the repository held symlinks which setuptools-scm does not deal with
properly.

This adapts the conftest fixture to deal with the transformation from folder
to an archive (still holding the symlinks).

This fixes the build [1]

[1] https://jenkins.softwareheritage.org/job/DTSCN/job/tests/194/console

Related to T2105

Test Plan

tox

Diff Detail

Repository

rDTSCN Code scanner

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Aug 6 2020, 12:05 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 6 2020, 12:05 PM

Build is green

Patch application report for D3720 (id=13109)

Rebasing onto efa0b6bdce...

Current branch diff-target is up to date.

Changes applied before test

commit 432c50daf2fc446d928fce2328f81bfd084bc9fc
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Aug 6 12:03:17 2020 +0200

    Transform inline sample-folder into archive and adapt fixture accordingly
    
    Since the setuptools-scm migration, the build fails because the sample-folder
    within the repository held symlinks which setuptools-scm does not deal with
    properly.
    
    This adapts the conftest fixture to deal with the transformation from folder
    to an archive (still holding the symlinks).
    
    This fixes the build [1]
    
    [1] https://jenkins.softwareheritage.org/job/DTSCN/job/tests/194/console
    
    Related to T2105

See https://jenkins.softwareheritage.org/job/DTSCN/job/tests-on-diff/36/ for more details.

Harbormaster completed remote builds in B14365: Diff 13109.Aug 6 2020, 12:07 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 6 2020, 1:04 PM

Closed by commit rDTSCN432c50daf2fc: Transform inline sample-folder into archive and adapt fixture accordingly (authored by ardumont). · Explain Why

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDTSCN432c50daf2fc: Transform inline sample-folder into archive and adapt fixture accordingly.