Details
Details
- Reviewers
olasd - Group Reviewers
Reviewers - Commits
- rDLSb84db26beebc: swh.lister.gitlab: Make the lister's task instance parametric
Diff Detail
Diff Detail
- Repository
- rDLS Listers
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
I don't much like the pattern of implicit *args and **kwargs on the leaf tasks: it makes it harder to discover what the arguments are supposed to look like, and it pushes "bug discovery" further down the stack if we change the function signatures.
I'd almost suggest making the leaf GitLab tasks have explicit signatures for run() (that just call super().run) but that's a "bit" overkill.
I'm okay with the changes to the base classes.
| swh/lister/bitbucket/tasks.py | ||
|---|---|---|
| 13 ↗ | (On Diff #1147) | That shouldn't be necessary. |
| swh/lister/debian/tasks.py | ||
| 13 ↗ | (On Diff #1147) | That shouldn't be necessary. |
| 16 ↗ | (On Diff #1147) | That shouldn't be necessary. |
| swh/lister/github/tasks.py | ||
| 13 ↗ | (On Diff #1147) | That shouldn't be necessary. |
| swh/lister/gitlab/tasks.py | ||
|---|---|---|
| 13–16 | I guess this lister_name argument is not needed anymore :) | |
| swh/lister/gitlab/tasks.py | ||
|---|---|---|
| 13–16 | Yes, and it's no longer there but i fear that updating the diff will mess it up. | |