Add test to ensure storage/objstorage consistency is kept at all times
ClosedPublic
Actions

Authored by olasd on May 11 2018, 12:13 PM.

Details

Reviewers

Group Reviewers

Commits

rDSTOC721d08840228: Add test to ensure storage/objstorage consistency is kept at all times
R65:721d08840228: Add test to ensure storage/objstorage consistency is kept at all times
rDSTO721d08840228: Add test to ensure storage/objstorage consistency is kept at all times

Summary

The behavior of storage when the underlying objstorage had an exception was
never actually tested. This new test weeded out a bug in the threaded
implementation for copy_to.

Test Plan

the new test passes

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.May 11 2018, 12:13 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 11 2018, 12:13 PM

Harbormaster completed remote builds in B1228: Diff 1064.May 11 2018, 12:13 PM

ardumont accepted this revision.May 11 2018, 5:45 PM

This revision is now accepted and ready to land.May 11 2018, 5:45 PM

Closed by commit rDSTO721d08840228: Add test to ensure storage/objstorage consistency is kept at all times (authored by olasd). · Explain WhyMay 12 2018, 5:47 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

storage/

db.py

22 lines

tests/

test_storage.py

17 lines

Diff 1066

View Options

swh/storage/db.py