Differential D3275

cassandra.storage: Write origin-visit-status once in journal
ClosedPublic
Actions

Authored by ardumont on Jun 12 2020, 6:53 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Maniphest Tasks

T2310: Make origin visits immutable

Commits

rDSTO33efdb0dd488: storage*: Do not write twice origin-visit-status in journal

Summary

Currently this wrote twice those objects, possibly introduced in D3212

Related to T2310

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Branch

drop-origin-visit-update

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 12823
Build 19517: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 19516: arc lint + arc unit

Event Timeline

ardumont created this revision.Jun 12 2020, 6:53 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 12 2020, 6:53 PM

ardumont added inline comments.Jun 12 2020, 6:54 PM

swh/storage/cassandra/storage.py
839	This does the writes already ;)

ardumont added a child revision: D3276: storage*: Remove origin-visit-update endpoint.Jun 12 2020, 6:55 PM

Build is green

Patch application report for D3275 (id=11616)

Rebasing onto 37c45300bc...

Current branch diff-target is up to date.

Changes applied before test

commit 33efdb0dd488cfb6f8d189a696863dd540fd3734
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jun 12 18:51:47 2020 +0200

    storage*: Do not write twice origin-visit-status in journal
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/266/ for more details.

Harbormaster completed remote builds in B12823: Diff 11616.Jun 12 2020, 7:01 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 12 2020, 7:12 PM

Closed by commit rDSTO33efdb0dd488: storage*: Do not write twice origin-visit-status in journal (authored by ardumont). · Explain Why

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTO33efdb0dd488: storage*: Do not write twice origin-visit-status in journal.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

swh/

storage/

cassandra/

storage.py

1 line

93%

Diff 11616

View Options

swh/storage/cassandra/storage.py

cassandra.storage: Write origin-visit-status once in journalClosedPublicActions