Page MenuHomeSoftware Heritage

Make deposit client deal properly with maintenance issues
ClosedPublic

Authored by ardumont on Mon, May 11, 5:55 PM.

Details

Summary

Prior to this commit, this expected to parse properly the api response. It
could not as the response was not in the proper format.

This also fixes incomplete test committed by mistake in
c64ee54311f724fb49a8b62918b40db7ea2fc019

(To ensure everything builds fine.)

Related to T2401

Test Plan

tox

Diff Detail

Repository
rDDEP Push deposit
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Mon, May 11, 5:55 PM

Build is green

Patch application report for D3139 (id=11152)

Rebasing onto d4a27a8acf...

Current branch diff-target is up to date.
Changes applied before test
commit 85e1ff3eea6f74a5d297224ec99c82aa08517836
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon May 11 17:52:55 2020 +0200

    Make deposit client deal properly with maintenance issues
    
    Prior to this commit, this expected to parse properly the api response. It
    could not as the response was not in the proper format.
    
    This also fixes incomplete test committed by mistake in
    c64ee54311f724fb49a8b62918b40db7ea2fc019

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/18/ for more details.

ardumont added inline comments.Mon, May 11, 5:58 PM
swh/deposit/tests/cli/test_client.py
82

This was committed by mistake...

This revision was not accepted when it landed; it landed in state Needs Review.Mon, May 11, 5:59 PM
This revision was automatically updated to reflect the committed changes.